feat(whitelabel): use favicon loaded from configs as default for notifications #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set defaults for favicon and title on store. - Create hook and getters for favicon, title and logo. - Create a component for the logo which can be reused in different points of the project. - Cleanup unused assets and move svgs inside assets folder. - Prepare splash view to use dynamic logo component. - Use png for the favicon in order to make it usable also for the notification system. - Set favicon and title on the document even if the request fails, defaults will be used in case. - Improve typing of svg assets module refs: SHELL-61 fix: relative path for favicon
…fications refs: SHELL-61
gnekoz
approved these changes
Mar 8, 2023
CerDennis
approved these changes
Mar 8, 2023
nubsthead
approved these changes
Mar 9, 2023
CataldoMazzilli
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(whitelabel): use favicon loaded from configs as default for notifications
fix(whitelabel): load favicon and title also when request fails
refs: SHELL-61