Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(settings): choose the "from" address within all the available addresses #177

Merged
merged 6 commits into from
Jan 4, 2023
Merged

feat(settings): choose the "from" address within all the available addresses #177

merged 6 commits into from
Jan 4, 2023

Conversation

gnekoz
Copy link
Contributor

@gnekoz gnekoz commented Dec 27, 2022

  • refactor: fixed/added types
  • refactor: changed the type-check of the identity to avoid relying on the translation value

@gnekoz
feat(settings): choose the "from" address within all the available ad…
e132a8a 
…dresses

refactor: fixed/added types
refactor: changed the type-check of the identity to avoid relying on the translation value
giuliano176
giuliano176 previously approved these changes Dec 27, 2022
View reviewed changes
beawar
beawar reviewed Dec 28, 2022
View reviewed changes
Copy link
Contributor

@beawar beawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it manually because I don't know how to do it

src/settings/components/account-settings/settings-sent-messages.tsx Outdated Show resolved Hide resolved
@gnekoz gnekoz requested review from beawar and giuliano176 December 29, 2022 10:05
giuliano176
giuliano176 previously approved these changes Dec 29, 2022
View reviewed changes
@gnekoz gnekoz requested a review from giuliano176 December 29, 2022 13:22
@beawar beawar merged commit ce36e6d into devel Jan 4, 2023
@beawar beawar deleted the IRIS-3609-email-selection branch January 4, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuliano176 giuliano176 giuliano176 approved these changes

@nubsthead nubsthead nubsthead approved these changes

@CataldoMazzilli CataldoMazzilli CataldoMazzilli approved these changes

@beawar beawar beawar approved these changes

@dhavaldodiya dhavaldodiya Awaiting requested review from dhavaldodiya

@FrancescoGottardi FrancescoGottardi Awaiting requested review from FrancescoGottardi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gnekoz @beawar @CataldoMazzilli @nubsthead @giuliano176