fix: edit roboto resource link to be non blocking #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: IRIS-3540
beawar
requested review from
nubsthead,
giuliano176,
dhavaldodiya,
FrancescoGottardi and
gnekoz
as code owners
|
Solution taken from https://pagespeedchecklist.com/asynchronous-google-fonts |
nubsthead
previously approved these changes
Dec 5, 2022
gnekoz
previously approved these changes
Dec 5, 2022
Introduced with caff759
|
Thanks to @nubsthead for discovering a problem with fonts loading at every rerender. WIth #156 entered an unwanted change to the UIThemeProvider, the add of the |
nubsthead
approved these changes
Dec 5, 2022
CataldoMazzilli
approved these changes
Dec 6, 2022
beawar
deleted the
hotfix/IRIS-3540-change-roboto-request-to-non-blocking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: IRIS-3540