feat(whitelabel): use configs to set logo, title, favicon and dark mode default #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: IRIS-3446
…de default * feat: whitelabeling favicon and title * refactor: move darkmode setting and config in a custom hook * refactor: move error prone string in a getter * feat: use carbonioWebUiDarkMode as appearance setting fallback value refs: IRIS-3446, IRIS-3471, IRIS-3472
CataldoMazzilli
requested review from
nubsthead,
geeky-abhishek,
giuliano176,
dhavaldodiya,
FrancescoGottardi and
gnekoz
as code owners
beawar
approved these changes
Nov 18, 2022
giuliano176
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: IRIS-3446, IRIS-3471, IRIS-3472