Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use v23 as base in upgrade tests #3272

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Dec 10, 2024

Summary by CodeRabbit

  • New Features

    • Upgraded the zetanode component to version 23.1.5 for both source and binary builds.
  • Bug Fixes

    • Resolved issues related to the previous versioning scheme by updating build arguments to reflect the latest release.

@gartnera gartnera added the no-changelog Skip changelog CI check label Dec 10, 2024
@gartnera gartnera requested a review from a team as a code owner December 10, 2024 19:39
Copy link
Contributor

coderabbitai bot commented Dec 10, 2024

📝 Walkthrough

Walkthrough

The changes in this pull request focus on updating the Makefile for the zetanode component, specifically modifying the OLD_VERSION build argument in the zetanode-upgrade targets. The version is upgraded from 'release/v22' to 'release/v23' for both source and binary builds, reflecting a transition to a newer release. The overall control flow and functionality for building and upgrading the zetanode remain unchanged, with no new commands or targets introduced.

Changes

File Change Summary
Makefile Updated OLD_VERSION from 'release/v22' to 'release/v23' in zetanode-upgrade targets.
Makefile Updated OLD_VERSION from https://github.com/zeta-chain/node/releases/download/v22.1.1 to https://github.com/zeta-chain/node/releases/download/v23.1.5 in zetanode-upgrade targets.

Possibly related PRs

  • chore: use v22 as base in upgrade tests #3200: This PR updates the OLD_VERSION in the Makefile for the zetanode-upgrade target from release/v21 to release/v22, which is directly related to the versioning changes made in the main PR that upgrades from release/v22 to release/v23.

Suggested labels

UPGRADE_LIGHT_TESTS

Suggested reviewers

  • fbac
  • skosito
  • kingpinXD
  • ws4charlie
  • brewmaster012
  • swift1337
  • lumtis

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3a8fa1e and 519a978.

📒 Files selected for processing (1)
  • Makefile (2 hunks)
🔇 Additional comments (2)
Makefile (2)

330-332: Verify source version reference

The change to use 'release/v23' as the base version for upgrade tests looks correct.

Let's verify the existence of this release branch:

✅ Verification successful

Base version reference for upgrade tests is valid

The release/v23 branch exists in the repository, confirming that the upgrade test configuration is using a valid base version.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify the release/v23 branch exists and is valid
gh api repos/zeta-chain/node/branches/release/v23 --jq '.name'

Length of output: 74


339-342: Verify binary version reference and consistency

The change to use v23.1.5 for binary builds aligns with the source version update.

Let's verify this release exists and matches our version scheme:

✅ Verification successful

Binary version reference verified successfully

The GitHub release tag v23.1.5 exists and follows the correct version format (v23.x.x). The version reference in the Makefile is valid and consistent with our versioning scheme.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify v23.1.5 release exists and contains required artifacts
gh api repos/zeta-chain/node/releases/tags/v23.1.5 --jq '.tag_name'

# Ensure version format consistency
if [[ "v23.1.5" =~ ^v23\.[0-9]+\.[0-9]+$ ]]; then
    echo "Version format is correct"
else
    echo "Version format is incorrect"
fi

Length of output: 177


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gartnera gartnera enabled auto-merge December 10, 2024 19:41
@gartnera gartnera added the UPGRADE_LIGHT_TESTS Run make start-upgrade-test-light label Dec 10, 2024
@gartnera gartnera added this pull request to the merge queue Dec 11, 2024
Merged via the queue into develop with commit 66adf1d Dec 11, 2024
63 of 67 checks passed
@gartnera gartnera deleted the upgrade-tests-v23 branch December 11, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Skip changelog CI check UPGRADE_LIGHT_TESTS Run make start-upgrade-test-light
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants