Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip solana unsupported transaction version (#3206) #3220

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Nov 26, 2024

Backport #3206 to unblock solana.

{"level":"error","chain":901,"chain_network":"solana","module":"inbound","error":"error GetTransaction for chain 901 sig Wqgj7hAaUUSfLzieN912G7GxyGHijzBZgY135NtuFtPRjevK8DnYjWwQZy7LAKFQZu582wsjuab2QP27VMUJzAi: (*jsonrpc.RPCError)(0x40322f5200)({\n Code: (int) -32015,\n Message: (string) (len=175) \"Transaction version (0) is not supported by the requesting client. Please try the request again with the following configuration parameter: \\\"maxSupportedTransactionVersion\\\": 0\",\n Data: (interface {}) <nil>\n})\n","time":"2024-11-26T17:02:43Z","message":"WatchInbound: observeInbound error"}

Will be released as v23.1.1

* fix solana testnet unsupported version 0

* add changelog entry

* correct variable name; explicitly return a 'skip' flag to be more redable

* fix unit test

* Simplify RPC API

* Comment test case

* clean up commented test

---------

Co-authored-by: Dmitry S <[email protected]>
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 32 lines in your changes missing coverage. Please review.

Project coverage is 62.64%. Comparing base (bccb1cc) to head (a8ce6d8).
Report is 1 commits behind head on release/v23.

Files with missing lines Patch % Lines
zetaclient/chains/solana/observer/inbound.go 0.00% 20 Missing ⚠️
zetaclient/chains/solana/rpc/rpc.go 0.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release/v23    #3220      +/-   ##
===============================================
- Coverage        62.69%   62.64%   -0.06%     
===============================================
  Files              425      424       -1     
  Lines            30231    30243      +12     
===============================================
- Hits             18954    18946       -8     
- Misses           10437    10457      +20     
  Partials           840      840              
Files with missing lines Coverage Δ
zetaclient/chains/solana/signer/signer.go 23.48% <100.00%> (+0.31%) ⬆️
zetaclient/keys/relayer_key.go 90.00% <100.00%> (ø)
zetaclient/chains/solana/rpc/rpc.go 0.00% <0.00%> (ø)
zetaclient/chains/solana/observer/inbound.go 31.25% <0.00%> (-1.25%) ⬇️

@zeta-chain zeta-chain deleted a comment from coderabbitai bot Nov 26, 2024
@gartnera gartnera merged commit a87243a into release/v23 Nov 27, 2024
42 of 47 checks passed
@gartnera gartnera deleted the solana-unsupported-transaction-v23 branch November 27, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SOLANA_TESTS Run make start-solana-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants