fix(e2e): wrong evm client used for TestDAppV2ZEVM

[lumtis]

Description

Replace EVMClient with ZEVMClient.

The bug prevents running DepositAndCall tests on live networks

Summary by CodeRabbit

• New Features

  • Updated the contract instantiation process for improved interaction with the ZEVM context.

• Bug Fixes

  • Corrected the client used for initializing the TestDAppV2 contract, enhancing its functionality within the ZEVM environment.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes introduced in this pull request involve modifications to the setContractsFromConfig function located in the cmd/zetae2e/config/contracts.go file. The primary alteration is the replacement of the EVMClient with the ZEVMClient for the instantiation of the TestDAppV2 contract. This adjustment impacts how the contract interacts with the client, reflecting a transition to a different operational context while preserving the existing logic for contract setup.

Changes

File Path	Change Summary
cmd/zetae2e/config/contracts.go	Updated setContractsFromConfig to use r.ZEVMClient instead of r.EVMClient for TestDAppV2 instantiation.

Possibly related PRs

• test(e2e): update testdapp contract in deploy test #3042: The changes in this PR involve updating the deployment process to use the TestDAppV2 contract, which is directly related to the modifications made in the setContractsFromConfig function that now utilizes the TestDAppV2 contract in the ZEVM context.

Suggested labels

no-changelog, UPGRADE_TESTS

Suggested reviewers

• skosito
• kingpinXD
• fbac
• brewmaster012
• swift1337
• ws4charlie

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 8776a6a and 0239f51.

📒 Files selected for processing (1)

• cmd/zetae2e/config/contracts.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

cmd/zetae2e/config/contracts.go (1)

Pattern **/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.

🔇 Additional comments (1)

cmd/zetae2e/config/contracts.go (1)

280-283: LGTM: Correct client usage for ZEVM context.

The change correctly uses ZEVMClient instead of EVMClient for initializing TestDAppV2ZEVM, which aligns with the contract's ZEVM context and matches the pattern used by other ZEVM contracts in this file.

Let's verify that all ZEVM contracts consistently use ZEVMClient:

✅ Verification successful

ZEVM contracts consistently use the correct client

The verification confirms that all ZEVM contract initializations in cmd/zetae2e/config/contracts.go consistently use ZEVMClient, including the modified TestDAppV2ZEVM. The change aligns with the established pattern across 14 ZEVM contract initializations.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify consistent client usage for ZEVM contracts
# Expect: All ZEVM contract initializations should use ZEVMClient

# Search for ZEVM contract initializations
rg -U "New.*\(.*ZEVMClient\)" cmd/zetae2e/config/contracts.go

Length of output: 1174

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.