test(e2e): update testdapp contract in deploy test #3042
Conversation
lumtis
requested review from
brewmaster012,
kingpinXD,
ws4charlie,
skosito,
swift1337 and
fbac
as code owners
📝 WalkthroughWalkthroughThe pull request introduces significant updates to the contract deployment functionality in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
e2e/e2etests/test_deploy_contract.go (1)
64-66: LGTM: Consistent implementation with ZEVM deploymentThe EVM deployment changes mirror the ZEVM updates, maintaining consistency across both deployment functions. Consider adding the same documentation about parameter removal here as well.
func deployEVMTestDApp(r *runner.E2ERunner) (ethcommon.Address, error) { + // Note: ConnectorEthAddr and ZetaEthAddr parameters were removed in TestDAppV2 addr, tx, _, err := testdappv2.DeployTestDAppV2( r.EVMAuth, r.EVMClient,
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- e2e/e2etests/test_deploy_contract.go (3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
e2e/e2etests/test_deploy_contract.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.
🔇 Additional comments (2)
e2e/e2etests/test_deploy_contract.go (2)
11-11: LGTM: Import statement updated correctlyThe import statement has been properly updated to use the new
testdappv2package, aligning with the PR's objective to replace the deprecated TestDapp contract.
45-47: Verify TestDAppV2 contract implementationThe deployment has been updated to use TestDAppV2. Let's verify the contract's existence and implementation.
Consider documenting parameter removal
The removal of
ConnectorZEVMAddrandWZetaAddrparameters suggests a significant change in contract initialization. Consider adding a comment explaining why these parameters are no longer needed.func deployZEVMTestDApp(r *runner.E2ERunner) (ethcommon.Address, error) { + // Note: ConnectorZEVMAddr and WZetaAddr parameters were removed in TestDAppV2 addr, tx, _, err := testdappv2.DeployTestDAppV2( r.ZEVMAuth, r.ZEVMClient,✅ Verification successful
The files exist, but we need to verify:
- The contract implementation to understand parameter removal
- Usage patterns across tests to ensure consistency
This will help us validate if the parameter removal is intentional and properly handled across the codebase.
Parameter removal is correct and well-implemented
The contract implementation shows that
TestDAppV2is designed to work withoutConnectorZEVMAddrandWZetaAddrparameters. The contract focuses on message handling, ERC20 interactions, and revert scenarios without dependencies on these addresses. All deployment calls across the codebase consistently use the simplified parameter pattern.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify TestDAppV2 contract exists and check its implementation echo "Checking TestDAppV2 contract existence and implementation..." fd -e sol -e go "TestDAppV2"Length of output: 238
Script:
#!/bin/bash # Check TestDAppV2 contract implementation and parameter changes echo "Checking TestDAppV2 contract implementation..." cat pkg/contracts/testdappv2/TestDAppV2.sol echo -e "\nChecking contract deployment usage across tests..." rg -A 3 "DeployTestDAppV2"Length of output: 6515
Description
TestDAppV2 has replaced TestDapp, replaces the contract in the deploy test as the later will no longer be deployed
Summary by CodeRabbit
testdappv2.These changes enhance the efficiency and clarity of the contract deployment process for users.