chore: use prebuilt bitcoin-node-sidecar #2989
Conversation
gartnera
requested review from
brewmaster012,
kingpinXD,
lumtis,
ws4charlie,
skosito,
swift1337 and
fbac
as code owners
📝 WalkthroughWalkthroughThis pull request involves the deletion of several files related to the Bitcoin Sidecar project, including a Dockerfile, TypeScript configuration, and various source files that implemented client functionality for Bitcoin transactions. The changes indicate a significant restructuring or potential discontinuation of the project, as key components such as the client implementation and configuration files have been removed. Additionally, the Docker Compose configuration has been updated to use a pre-built image instead of a local build context. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
contrib/localnet/docker-compose.yml (1)
Line range hint
231-241: Prebuilt image implementation approved with a maintenance consideration.The transition to a prebuilt image (
ghcr.io/zeta-chain/node-localnet-bitcoin-sidecar:e0205d7) aligns with the PR objective of enhancing CI performance. This change eliminates the need for building the sidecar during each CI run, potentially saving 30 to 60 seconds per execution.Consider implementing a strategy for keeping the image tag up-to-date:
- Use a more general tag (e.g.,
latestorstable) for easier updates.- Implement a periodic review process to ensure the image remains current.
- Utilize a CI/CD pipeline to automatically update the tag when a new version is available.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (8)
- contrib/localnet/bitcoin-sidecar/Dockerfile (0 hunks)
- contrib/localnet/bitcoin-sidecar/js/package.json (0 hunks)
- contrib/localnet/bitcoin-sidecar/js/src/client.ts (0 hunks)
- contrib/localnet/bitcoin-sidecar/js/src/index.ts (0 hunks)
- contrib/localnet/bitcoin-sidecar/js/src/script.ts (0 hunks)
- contrib/localnet/bitcoin-sidecar/js/src/tsconfig.json (0 hunks)
- contrib/localnet/bitcoin-sidecar/js/src/util.ts (0 hunks)
- contrib/localnet/docker-compose.yml (1 hunks)
💤 Files with no reviewable changes (7)
- contrib/localnet/bitcoin-sidecar/Dockerfile
- contrib/localnet/bitcoin-sidecar/js/package.json
- contrib/localnet/bitcoin-sidecar/js/src/client.ts
- contrib/localnet/bitcoin-sidecar/js/src/index.ts
- contrib/localnet/bitcoin-sidecar/js/src/script.ts
- contrib/localnet/bitcoin-sidecar/js/src/tsconfig.json
- contrib/localnet/bitcoin-sidecar/js/src/util.ts
🧰 Additional context used
🔇 Additional comments (1)
contrib/localnet/docker-compose.yml (1)
Line range hint
231-237: Command formatting enhancement approved.The reformatting of the
bitcoinservice command improves readability without altering functionality. This change adheres to best practices for Docker Compose file maintainability.
Description
Use prebuilt bitcoin-node-sidecar from https://github.com/zeta-chain/node-localnet-bitcoin-sidecar to improve E2E CI performance. Building this every E2E run wastes 30-60 seconds.
How Has This Been Tested?
Summary by CodeRabbit
bitcoin-node-sidecarservice by switching from a build configuration to an image specification.