Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 ERC20 Custody contract pause is incompatible with V1 #3000

Closed
gartnera opened this issue Oct 11, 2024 · 1 comment · Fixed by #3006
Closed

V2 ERC20 Custody contract pause is incompatible with V1 #3000

gartnera opened this issue Oct 11, 2024 · 1 comment · Fixed by #3006
Assignees
Labels
bug Something isn't working

Comments

@gartnera
Copy link
Member

The V2 ERC20 Custody contract does not allow the TSS address to pause:

https://github.com/zeta-chain/protocol-contracts/blob/475acfac26eff67472136fce2eb84f4dbfb5ea70/v2/contracts/evm/ERC20Custody.sol#L38-L49

The V1 ERC20 Custody contract only allows the TSS address to pause:

https://github.com/zeta-chain/protocol-contracts/blob/main/v1/contracts/evm/ERC20Custody.sol#L118-L127

This means that the zetaclient func (signer *Signer) signUpdateERC20CustodyPauseStatusCmd does not work on V2.

We either need to:

  • Allow TSS to pause
  • use deployer account to pause in e2e tests

This results in the admin e2e tests being broken. Seems to have been broken by #2932 when we moved to the V2 ERC20 custody contract by default

@gartnera gartnera added the bug Something isn't working label Oct 11, 2024
@lumtis
Copy link
Member

lumtis commented Oct 11, 2024

Good catch, it seems to make sense to add pauser role to TSS as well cc @skosito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants