We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The V2 ERC20 Custody contract does not allow the TSS address to pause:
https://github.com/zeta-chain/protocol-contracts/blob/475acfac26eff67472136fce2eb84f4dbfb5ea70/v2/contracts/evm/ERC20Custody.sol#L38-L49
The V1 ERC20 Custody contract only allows the TSS address to pause:
https://github.com/zeta-chain/protocol-contracts/blob/main/v1/contracts/evm/ERC20Custody.sol#L118-L127
This means that the zetaclient func (signer *Signer) signUpdateERC20CustodyPauseStatusCmd does not work on V2.
func (signer *Signer) signUpdateERC20CustodyPauseStatusCmd
We either need to:
This results in the admin e2e tests being broken. Seems to have been broken by #2932 when we moved to the V2 ERC20 custody contract by default
The text was updated successfully, but these errors were encountered:
Good catch, it seems to make sense to add pauser role to TSS as well cc @skosito
Sorry, something went wrong.
skosito
Successfully merging a pull request may close this issue.
The V2 ERC20 Custody contract does not allow the TSS address to pause:
https://github.com/zeta-chain/protocol-contracts/blob/475acfac26eff67472136fce2eb84f4dbfb5ea70/v2/contracts/evm/ERC20Custody.sol#L38-L49
The V1 ERC20 Custody contract only allows the TSS address to pause:
https://github.com/zeta-chain/protocol-contracts/blob/main/v1/contracts/evm/ERC20Custody.sol#L118-L127
This means that the zetaclient
func (signer *Signer) signUpdateERC20CustodyPauseStatusCmd
does not work on V2.We either need to:
This results in the admin e2e tests being broken. Seems to have been broken by #2932 when we moved to the V2 ERC20 custody contract by default
The text was updated successfully, but these errors were encountered: