From ee60d893829eabb320de57dfffa4c409efc7f78d Mon Sep 17 00:00:00 2001 From: Dan Rose Date: Fri, 14 Jun 2024 23:08:36 -0500 Subject: [PATCH] Don't redundantly redefine macOS architecture `CMAKE_OSX_ARCHITECTURES` is already set in `build.js`, so there's no need to set it in `binding.gyp`. In fact, if the architecture is inferred from the host (and not via the `$ARCH` env var), this previously resulted in incorrectly cross-compiling. --- binding.gyp | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/binding.gyp b/binding.gyp index 280b468c..9b979e20 100644 --- a/binding.gyp +++ b/binding.gyp @@ -134,12 +134,6 @@ ], 'GCC_ENABLE_CPP_EXCEPTIONS': 'YES', 'GCC_ENABLE_EXCEPTIONS': 'YES', - 'OTHER_CFLAGS': [ - "