From fa466a948d89707b6c1f037b3a524548bd01c00f Mon Sep 17 00:00:00 2001 From: Min RK Date: Wed, 26 Jul 2023 16:26:29 -0700 Subject: [PATCH 1/2] bump coverage in test env requires Python 3.7 --- test-requirements.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test-requirements.txt b/test-requirements.txt index 1af55764d..a2d505c58 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -2,7 +2,8 @@ black; platform_python_implementation != "PyPy" # gevent wheels on mac cause Illegal Instruction codecov # coverage 5 has issues with Cython: https://github.com/cython/cython/issues/3515 -coverage<5 +coverage<5; python_version < "3.7" +coverage>=7.1; python_version >= "3.7" cython; platform_python_implementation != "PyPy" # required for Cython tests cython>=3.0.0b3; platform_python_implementation != "PyPy" and python_version >= "3.12" # required for Cython tests flake8 From 3bec21d7589212936da335ca18d9433c62f04164 Mon Sep 17 00:00:00 2001 From: Min RK Date: Wed, 26 Jul 2023 16:46:45 -0700 Subject: [PATCH 2/2] disable Cython coverage for now --- .github/workflows/test.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ae33efab2..4cabd1d8c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -105,10 +105,11 @@ jobs: grep -v plugins .coveragerc > .coveragerc-save mv .coveragerc-save .coveragerc - - name: enable Cython coverage - if: "! (startsWith(matrix.python, 'pypy') || startsWith(matrix.python, '3.12'))" - run: | - echo "PYZMQ_CYTHON_COVERAGE=1" >> "$GITHUB_ENV" + # - name: enable Cython coverage + # if: "! (startsWith(matrix.python, 'pypy') || startsWith(matrix.python, '3.12'))" + # run: | + # echo "PYZMQ_CYTHON_COVERAGE=1" >> "$GITHUB_ENV" + # preserve pip cache to speed up installation - name: Cache pip uses: actions/cache@v3