Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation errors caused by parameters not declared in this scope #801

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Fix compilation errors caused by parameters not declared in this scope #801

merged 1 commit into from
Apr 22, 2020

Conversation

Harvey-Liu
Copy link
Contributor

No description provided.

@zcabot
Copy link

zcabot commented Apr 17, 2020 •
edited
Loading

Contributor requirements have been met.

@pepone
Copy link
Member

pepone commented Apr 18, 2020

Hi @Harvey-Liu thanks for the contribution can you review the contributor agreement posted above by zcabot, we will merge this once you send us the signed agreement.

Cheers,
Jose

@Harvey-Liu
Copy link
Contributor Author

Hi @pepone , I have sent the signed agreement to the mailbox

@bernardnormier
Copy link
Member

Hi @pepone , I have sent the signed agreement to the mailbox

Unfortunately we did not receive it. Can you please email it again to [email protected]?

Thanks,
Bernard

@Harvey-Liu
Copy link
Contributor Author

Hi @pepone , I have sent the signed agreement to the mailbox

Unfortunately we did not receive it. Can you please email it again to [email protected]?

Thanks,
Bernard

Ok, I have sent it again, the main body of the email is Harvey-Liu ZCA

Thanks,
Harvey

@InsertCreativityHere
Copy link
Member

We got it this time! Thanks again for the catch!

@externl externl requested a review from pepone April 22, 2020 15:12
@externl externl added the bug label Apr 22, 2020
@pepone pepone merged commit 0c5f00c into zeroc-ice:3.7 Apr 22, 2020
externl pushed a commit that referenced this pull request Apr 23, 2020
@Harvey-Liu @externl
Fix compilation errors caused by parameters not declared in this scope (
4973122 
#801)
@externl
Copy link
Member

externl commented Apr 23, 2020

I cherry-picked this into master at 4973122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepone pepone pepone approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Harvey-Liu @zcabot @pepone @bernardnormier @InsertCreativityHere @externl