This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Enforce zosversion check when loading zos json files #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
force-pushed
the
feature/check-zosversion-#131
branch
from
b87d251 to
8e5be54
Compare
facuspagnuolo
approved these changes
Oct 3, 2018
|
CI is failing with the following error:
I hate it when my code is smarter than me. |
spalladino
force-pushed
the
feature/check-zosversion-#131
branch
from
534911c to
0c17799
Compare
This was referenced Oct 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a zos.json or zos.network.json file, either local or from a dependency, it is now checked that the json file contains a zosversion equal to 2, or an error message is thrown.
This PR is part of the fixes for issues #159 and #131. Another PR is pending to implement the same logic in 1.4.x.