This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Update simple-example to use new simple project #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facuspagnuolo
previously approved these changes
Sep 17, 2018
|
@facuspagnuolo it seems I hadn't properly configured the "do not dismiss stale reviews" on the project (I was sure I had done it, but who knows). Could you re-approve if you don't mind? |
spalladino
added a commit
that referenced
this pull request
Sep 24, 2018
* Refactor simple-example to use new simple project and add tests * Export SimpleProject from lib * Accept instances or addresses in upgradeProxy for simplicity * Compile contracts before testing
spalladino
added a commit
that referenced
this pull request
Sep 24, 2018
* Refactor simple-example to use new simple project and add tests * Export SimpleProject from lib * Accept instances or addresses in upgradeProxy for simplicity * Compile contracts before testing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of manually deploying logic contracts, proxies, and initializing them, simple-example now uses SimpleProject. Also adds a test to ensure it keeps working with the latest version of lib (side note: it wasn't).