This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
TestApp fix to work with multiple deps models #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename TestApp to ProjectApp - Fix most of TestApp tests
spalladino
reviewed
Sep 8, 2018
| @@ -8,7 +8,8 @@ import ControllerFor from '../models/network/ControllerFor'; | |||
| */ | |||
| export default async function testApp(txParams = {}, networkFile = undefined) { | |||
There was a problem hiding this comment.
I'd rename it to TestProject instead of ProjectApp, and consider supporting libs as well as apps
Implemented TestLib function to test Lib projects
jbcarpanelli
force-pushed
the
fix/testapp
branch
from
3f123a1 to
2244f35
Compare
jbcarpanelli
added
topic:tools
and removed
status:in-progress
spalladino
approved these changes
Sep 10, 2018
spalladino
pushed a commit
that referenced
this pull request
Sep 24, 2018
* Add mock package with multiple stdlibs * Return controller AppProject instead of App * Rename TestApp to ProjectApp - Rename TestApp to ProjectApp - Fix most of TestApp tests * Rename testApp to ProjectApp * Switch from deployed deps to non-deployed deps * Fix remaining tests * Implement TestLib function Implemented TestLib function to test Lib projects * Unified TestLib and TestApp in favor of TestHelper
spalladino
pushed a commit
that referenced
this pull request
Sep 24, 2018
* Add mock package with multiple stdlibs * Return controller AppProject instead of App * Rename TestApp to ProjectApp - Rename TestApp to ProjectApp - Fix most of TestApp tests * Rename testApp to ProjectApp * Switch from deployed deps to non-deployed deps * Fix remaining tests * Implement TestLib function Implemented TestLib function to test Lib projects * Unified TestLib and TestApp in favor of TestHelper
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've renamed the
TestAppmodel toTestHelper. It now works fine with app projects that have multiple stdlibs, as well as lib projects.