This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
New publish command #257
Merged
New publish command #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pending transfering ownership of proxies to app. Can be merged in the meantime though. |
spalladino
added
status:to-review
|
@facuspagnuolo added proxies transfer, ready to review now. I'll rebase onto master in a few minutes. |
spalladino
force-pushed
the
feature/publish-command
branch
2 times, most recently
from
41a0a8c to
22c9dd7
Compare
For compatibility with upcoming publish command, since full terminology is being dropped.
spalladino
force-pushed
the
feature/publish-command
branch
from
3911f49 to
833fe62
Compare
facuspagnuolo
approved these changes
Oct 16, 2018
packages/cli/src/commands/init.js
Outdated
| @@ -11,18 +11,18 @@ const register = program => program | |||
| .command(signature, { noHelp: true }) | |||
| .usage('<project-name> [version]') | |||
| .description(description) | |||
| .option('--full', 'create an application, package, and implementation directory contracts to manage your project') | |||
| .option('--publish', 'automatically publishes your application upon pushing it to a network') | |||
There was a problem hiding this comment.
I'd use the same description you used for the publish command. Note that you are using project for the other and here you are using application
| set full(full) { | ||
| this.data.full = !!full | ||
| set publish(publish) { | ||
| this.data.publish = !!publish |
There was a problem hiding this comment.
IMO it should say published but I'm not sure if we are using that convention
| if (currentBlock - txBlock >= confirmations) return true; | ||
| await sleep(interval); | ||
| } | ||
| } |
|
|
||
| export default async function deploy(options) { | ||
| const oneDay = 60 * 60 * 24 | ||
| session({ expires: oneDay, ...options }) | ||
| log.base(`Pushing ZeppelinOS app with options ${JSON.stringify(options, null, 2)}...`) | ||
| const isLocalOrTest = options.network === 'local' || options.network === 'test' | ||
| if (isLocalOrTest) removeZosFiles(options) | ||
| await push({ deployLibs: isLocalOrTest, full: true, ...options }) | ||
| await push({ deployLibs: isLocalOrTest, ...options }) | ||
| await publish({ ...options }) |
spalladino
force-pushed
the
feature/publish-command
branch
from
833fe62 to
4a21bf6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
publishcommand that migrates the current app/lib from lightweight into a full app, by deploying a directory, package and app contracts.Also deprecates the
--fullflag forpush, and renames that flag ininitto--publish.Fixes #255