This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Handle initialize function lookup on dependencies contracts #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsing the linearized base contracts on contracts in dependencies failed, since their absolute paths pointed to inexistent directories in the local machine, as they were compiled somewhere else. Also, truffle uses prefixes when compiling contracts from dependencies, but not when compiling local contracts: this causes the absolute path not to match between the ImportDirective and the compiled artifact. To workaround this, we catch any errors on that lookup, and fall back to matching on the ABI directly by number of args only. If we detect more than one method, we fail. To allow the user to pinpoint a method, now we accept a fully qualified function name, like `myFunction(uint256,string)`. This shortcircuits the initializer function lookup, and goes straight for the ABI, matching by the specified argument types.
facuspagnuolo
approved these changes
Oct 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing the linearized base contracts on contracts in dependencies
failed, since their absolute paths pointed to inexistent directories in
the local machine, as they were compiled somewhere else. Also, truffle
uses prefixes when compiling contracts from dependencies, but not when
compiling local contracts: this causes the absolute path not to match
between the ImportDirective and the compiled artifact.
To workaround this, we catch any errors on that lookup, and fall back to
matching on the ABI directly by number of args only. If we detect more
than one method, we fail.
To allow the user to pinpoint a method, now we accept a fully qualified
function name, like
myFunction(uint256,string). This shortcircuits theinitializer function lookup, and goes straight for the ABI, matching by
the specified argument types.