This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Enhance cli outputs on error #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using zos-lib Logger class to keep track of error messages
packages/cli/src/scripts/create.js
Outdated
|
|
||
| return proxy; | ||
| } catch(error) { | ||
| log.error(error.message) |
There was a problem hiding this comment.
shouldn't we rethrow here? otherwise, we will be swallowing that error, for example, we are using this scripts programmatically in other projects and we expect them to fail if sth went wrong, we should write and rethrow I think
jbcarpanelli
force-pushed
the
enhance-cli-outputs-on-error
branch
from
ac4f518
to
4e25aba
Compare
|
I've implemented a new |
spalladino
approved these changes
Oct 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes zeppelinos/zos-cli#337.
successfully written zos.network.jsonto a less possitive-everything-is-fine-wohoo! message (Created zos.network.jsonorUpdated zos.network.json).zos.network.jsonfile if needed, whence only showing this message when the file is written.