This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Removed dependency names can no longer be reused. #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202.
I considered leaving a sentinel value to signal a name had been taken, but both
owner
andaddress
need to be obviously zeroed out, andstake
can be 0 (ifminimalStake
is 0), so I opted for adding an extra field. This should have a minimal impact on gas costs, sinceused
is packed alongsideowner
, emitting a singleSSTORE
/SLOAD
opcode when accessing (this was verified experimentally).I'm not 100% sure on the name (maybe
nameTaken
?), but this is an internal detail and not part of the API.