This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Added a storage gap at the end of Initializable's storage layout. #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nventuro it seems there was a test that was dependent on storage positions. Could you fix them? |
spalladino
approved these changes
Oct 10, 2018
|
Done! I also improved the wording of the comment, since it was very outdated. |
spalladino
approved these changes
Oct 10, 2018
| // - 0: Initializable storage | ||
| // - 1-50: Initailizable reserved storage (50 slots) | ||
| // - 51: initializerRan | ||
| // - 52: x |
There was a problem hiding this comment.
Shouldn't it be...?
// - 0: Initializable#initialized
// - 1: Initializable#initializing
// - 2-51: Initailizable#gap
// - 52: x
There was a problem hiding this comment.
No, both initialized and initializing are bool, so they are packed together into the same storage slot. The test uses InitiazableMock, which has bool initializerRan and uint256 x (in that order), those are not packed due to x using the full slot.
There was a problem hiding this comment.
If only we had a storage layout report... 😛
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created from the discussion in OpenZeppelin/openzeppelin-contracts-upgradeable#29
This is the same gap all
openzeppelin-zoscontracts have. My editor also removed some trailing whitespace, but I can undo that if you have strong feelings about it 😛