This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Add skip-compile option to push options #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
suggested changes
Oct 10, 2018
| @@ -16,6 +16,7 @@ program.Command.prototype.withNetworkOptions = function () { | |||
| program.Command.prototype.withPushOptions = function () { | |||
| return this | |||
| .option('--push [network]', 'push all changes to the specified network') | |||
| .option('--skip-compile', 'skips contract compilation') | |||
There was a problem hiding this comment.
Note that add already has a skip-compile option, and adding it here as well caused the option to be listed twice on add --help. We should remove it from the add command.
jbcarpanelli
added
status:ready-to-merge
facuspagnuolo
approved these changes
Oct 11, 2018
Nope, |
spalladino
approved these changes
Oct 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #67, this PR doesn't fix it though, as there is nothing to fix, but adds the
skip-compileoption to thewithPushOptionsfunction, to have the posibility to whether runtruffle compileor not.