Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Use canonical network names for zos network files #213

Merged
merged 2 commits into from
Oct 13, 2018

Conversation

jbcarpanelli
Copy link
Contributor

Fixes zeppelinos/zos-cli#342

Implemented a small function that takes the network id from web3.version and returns the network name based on this list.
I only added the most used networks, and if the network id doesn't match inside the switch clause, then I'm naming it as dev-NN, being NN the network id retrieved by web3, as proposed by @spalladino.

Copy link
Contributor

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, loved how succint the change is! Note that the integration tests are failing, since they still use the old naming for checking the proxy addresses (I think you'll need to modify run.js). We can merge as soon as that's fixed.

@spalladino spalladino added status:ready-to-merge Order mergify to merge and removed status:to-review Awaiting review labels Oct 11, 2018
@mergify mergify bot merged commit 0f9f33a into master Oct 13, 2018
@jbcarpanelli jbcarpanelli deleted the feature/use-canonical-network-names branch October 17, 2018 19:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready-to-merge Order mergify to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants