This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Retry gas estimation #198
Merged
Retry gas estimation #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a transaction to be sent fails, the error we'll actually get is an 'always failing transaction' on the estimateGas we sent first. However, we want to retry some transactions, as they may depend on a previous tx being mined, which may have not propagated yet. To handle these scenarios, we add 3 retries to gas estimation, separated by a small sleep interval. Fixes #192
spalladino
force-pushed
the
feature/retries-on-estimate-gas-#192
branch
from
ee28d4f
to
4e216c7
Compare
facuspagnuolo
approved these changes
Oct 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a transaction to be sent fails, the error we'll actually get is
an 'always failing transaction' on the estimateGas we sent first.
However, we want to retry some transactions, as they may depend on
a previous tx being mined, which may have not propagated yet.
To handle these scenarios, we add 3 retries to gas estimation,
separated by a small sleep interval.
Fixes #192