This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Check isConstructor for running initializable #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facuspagnuolo
approved these changes
Oct 3, 2018
|
|
||
| /// @dev Returns true if and only if the function is running in the constructor | ||
| function isConstructor() private view returns (bool) { | ||
| uint cs; |
There was a problem hiding this comment.
care being explicit uint256?
This change is required from oz-zos to handle certain scenarios with multiple inheritance. Original commit by @frangio is: OpenZeppelin/openzeppelin-contracts-upgradeable@6e0ace1#diff-0e8e787a34109f83dafec072d3664194
spalladino
force-pushed
the
feature/check-isconstructor-in-initializable
branch
from
d8bc96e
to
021b000
Compare
facuspagnuolo
deleted the
feature/check-isconstructor-in-initializable
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required from oz-zos to handle certain scenarios
with multiple inheritance. Original commit by @frangio is:
OpenZeppelin/openzeppelin-contracts-upgradeable@6e0ace1#diff-0e8e787a34109f83dafec072d3664194