Minor improvements to Basil demo #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/docs/basil.md
Outdated
| @@ -21,6 +21,7 @@ First we will need to [install Node.js following the instructions from their web | |||
| ```sh | |||
| mkdir basil | |||
| cd basil | |||
| truffle init | |||
There was a problem hiding this comment.
Let's avoid this line here since we are planning to start the project with zos instead
| @@ -165,7 +166,7 @@ Another common thing that happens when developing smart contracts for Ethereum i | |||
| We could modify `contracts/Basil.sol`. But now let's try something else. Let's make a new contract in `contracts/BasilERC721.sol`, that inherits from our initial version of Basil: | |||
|
|
|||
| ```sol | |||
| pragma solidity ^0.4.21; | |||
| pragma solidity ^0.4.24; | |||
There was a problem hiding this comment.
would you mind updating the project as well to follow this update?
added 2 commits
July 7, 2018 07:29
dougiebuckets
force-pushed
the
minor-improvements-to-basil-demo-#13
branch
from
361fd2c to
e5b5e4c
Compare
|
@facuspagnuolo Should be all set. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't completely resolve #13, but it's a start.