Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Promise support to text option? #492

Closed
ClementParis016 opened this issue Oct 25, 2017 · 1 comment
Closed

Adding Promise support to text option? #492

ClementParis016 opened this issue Oct 25, 2017 · 1 comment

Comments

@ClementParis016
Copy link

ClementParis016 commented Oct 25, 2017

Considering a reasonable amount of people want to perform asynchronous operations before a clipboard action, I think adding Promise support to the text option would be nice.

For example, you may want to call an API when clicking a button and use its response data as the value to be copied.

As far as I could explore the code, it doesn't seem to be such a big change to allow both a function or a promise to be passed as an argument.

What do you think @zenorocha ? I could start working on a PR if that feels right.

@zenorocha
Copy link
Owner

zenorocha commented Jan 23, 2018

Hey @ClementParis016,

I'm open to this change. Here's a proposal for it #517. Let me know what you think and if you're able to help.

Thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants