Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert banned/safe links domains config to a DB table #1043

Closed
Tracked by #1041
slint opened this issue Nov 4, 2024 · 0 comments · Fixed by #1048
Closed
Tracked by #1041

Convert banned/safe links domains config to a DB table #1043

slint opened this issue Nov 4, 2024 · 0 comments · Fixed by #1048

Comments

@slint
Copy link
Member

slint commented Nov 4, 2024

We want to store all the link domains in a table, and mark their status (banned/safe). Ideally when matching, we should be querying the DB like so:

        domain_parts = self.extract_domain(url)  # ['io', 'github', 'slint']

        """
        SELECT status
        FROM domain_tree
        WHERE domain LIKE 'io.github%'  -- this is a "good" domain and should match
        
        -- This is a "bad" more specific domain
        -- WHERE domain LIKE 'io.github.ketogummies'
        """
@slint slint self-assigned this Nov 4, 2024
@slint slint moved this to In progress in Sprint Q1/2025 Nov 4, 2024
@slint slint removed their assignment Nov 5, 2024
@github-project-automation github-project-automation bot moved this from In review 🔎 to To release 🤖 in Sprint Q1/2025 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant