Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

[BUG] - HTTPS Self Links Broken for Ports Other than 443 #194

Open
jbh opened this issue Oct 2, 2019 · 3 comments
Open

[BUG] - HTTPS Self Links Broken for Ports Other than 443 #194

jbh opened this issue Oct 2, 2019 · 3 comments

Comments

@jbh
Copy link

jbh commented Oct 2, 2019

When using HTTPS with a port other than 443, the self links returned remain HTTP.

Please see: https://github.com/zendframework/zend-view/blob/master/src/Helper/ServerUrl.php#L149

There are plenty of use cases where people will use ports other than 443 for their HTTPS needs. I believe this needs to be refactored to be less strict.

I'm happy to make the PR contribution, but I wanted to submit the issue first to make sure this doesn't break some standard.

@jbh jbh changed the title [BUG] [BUG] - HTTPS Self Links Broken for Ports Other than 443 Oct 2, 2019
@weierophinney
Copy link
Member

👍 for a PR for this!

@jbh
Copy link
Author

jbh commented Oct 2, 2019

Great. I'll work on doing that within the next two days. I have some other tasks in queue.

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-view; a new issue has been opened at laminas/laminas-view#3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants