Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

use strpos for fixed string matching #134

Closed
wants to merge 1 commit into from

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Apr 3, 2017

refs 8d18478

@glensc
Copy link
Contributor Author

glensc commented Apr 3, 2017

Travis build failure is not related to this PR.

PHP Fatal error:  Call to undefined method ZendTest\Mail\Protocol\SmtpPluginManagerCompatibilityTest::expectException() in /home/travis/build/zendframework/zend-mail/vendor/zendframework/zend-servicemanager/src/Test/CommonPluginManagerTrait.php on line 56
Fatal error: Call to undefined method ZendTest\Mail\Protocol\SmtpPluginManagerCompatibilityTest::expectException() in /home/travis/build/zendframework/zend-mail/vendor/zendframework/zend-servicemanager/src/Test/CommonPluginManagerTrait.php on line 56
Script phpunit --colors=always handling the test event returned with error code 255

@vaclavvanik
Copy link

Can u add test?

@Ocramius
Copy link
Member

Ocramius commented Apr 4, 2017

@vaclavvanik it's an idempotent change

src/Transport/Sendmail.php Outdated Show resolved Hide resolved
@glensc
Copy link
Contributor Author

glensc commented Apr 4, 2017

@vaclavvanik please read the PR summary. the tests are present in commit referred.
@Ocramius indeed. made it quickly without much thinking :)

glensc referenced this pull request Apr 4, 2017
@glensc
Copy link
Contributor Author

glensc commented Apr 4, 2017

this test passes now

➔ phpunit test/Transport/SendmailTest.php
PHPUnit 4.8.35 by Sebastian Bergmann and contributors.

.SS...

Time: 144 ms, Memory: 6.75MB

OK, but incomplete, skipped, or risky tests!
Tests: 6, Assertions: 13, Skipped: 2.

@glensc
Copy link
Contributor Author

glensc commented May 14, 2017

the requested changes are made. travis fault is not mine.
@Ocramius your review change is till pending, accept these.

glensc referenced this pull request Jun 8, 2017
@glensc
Copy link
Contributor Author

glensc commented Jun 8, 2017

@weierophinney this is complete now

@Ocramius Ocramius self-assigned this Mar 1, 2018
@Ocramius Ocramius added this to the 2.9.0 milestone Mar 1, 2018
Ocramius added a commit that referenced this pull request Mar 1, 2018
@Ocramius
Copy link
Member

Ocramius commented Mar 1, 2018

@glensc sorry for the long wait - I manually merged this via a6f72a1

Thanks!

@Ocramius Ocramius closed this Mar 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants