You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
I was looking through stream implementation. Relative stream and the stream it wraps are sharing same pointer, right?
So if we rewind wrapped stream, read on relative will return data before offset position.
Also tell() will give negative position, which is out of bounds error.
This shared pointer in streams looks extremely bug prone to me.
May be on seekable streams we should store pointer locally, set it before performing operation and record new position after doing it?
I was looking through stream implementation. Relative stream and the stream it wraps are sharing same pointer, right?
So if we rewind wrapped stream, read on relative will return data before offset position.
Also tell() will give negative position, which is out of bounds error.
This shared pointer in streams looks extremely bug prone to me.
May be on seekable streams we should store pointer locally, set it before performing operation and record new position after doing it?
As simplified example:
The text was updated successfully, but these errors were encountered: