This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Cleanup capabilities #81
Labels
Comments
Perhaps While we're there, the format for
Maybe the last is a bug, or maybe I'm missing something. I can see some value in being able say "yes, the adapter will store it, but won't return the same type", but |
@kynx The idea behind this is as follows:
$value = 100;
$storage->setItem('key', $value);
var_dump($value == $storage->getItem('key')); // true
var_dump($value === $storage->getItem('key')); // true
$value = new stdClass;
$storage->setItem('key', $value);
var_dump($value == $storage->getItem('key')); // true
var_dump($value === $storage->getItem('key')); // false
In case for integer it should be |
This repository has been closed and moved to laminas/laminas-cache; a new issue has been opened at laminas/laminas-cache#8. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Some of the current defined capabilities are very hard to understand/useless and I would like to define some of them.
minTtl
This defines the minimum supported TTL which is clear but only a handful people knows that this also defines the general TTL support.
There is no adapter having another value than 0 or 1 so this can be renamed to
ttlSupported
withbool
.->
minTtl
needs to be still available for BC reasons until the next major but can be marked deprecated.staticTtl
This defines how the expiration time will be calculated which is not a meaningful description.
true
means the expiration time will be calculated on read using the last-modification-time of the item, the current time and the current TTL optionfalse
means the expiration time will be calculated using the current TTL and the current time. It will be stored together with the itemThoughts for better names ?
expiredRead
There was the idea that it is possible to read an expired item by setting changing the TTL (like to 0 = infinitive) but this only works with
staticTtl=true
to make it possible using an expired item in cases regeneration breaks (like on failed DB connection).This is a useless capability because changing the TTL to something else automatically changes the expiration time of all stored items if
staticTtl=true
which means in case for infinity the item is no longer expired. -> Bam the item is no longer expired but this capability is for reading expired items and the nature ofstaticTtl
already defines this behavior.-> I would like to deprecate this capability and remove it in the next major version.
@kynx @Maks3w @Ocramius @ezimuel Thoughts ?
The text was updated successfully, but these errors were encountered: