Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always publish to npmjs.com main public registry #132

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

token-cjg
Copy link
Contributor

@token-cjg token-cjg commented Aug 9, 2022

Description

Make sure that we always publish to the main npmjs.com public registry.

Note, we use --@zendesk:registry=https://npmjs.com because configuration
in ~/.npmrc will override --registry=https://npmjs.com if set. [1]

[1]: https://stackoverflow.com/a/67691043

Checklist

  • 💂‍♂️ includes new unit and functional tests

Note, we use --@zendesk:registry=https://npmjs.com because configuration
in ~/.npmrc will override --registry=https://npmjs.com if set. [1]

[1]: https://stackoverflow.com/a/67691043
@token-cjg token-cjg requested a review from a team August 9, 2022 03:45
@token-cjg token-cjg marked this pull request as ready for review August 9, 2022 03:45
@anushkafka
Copy link
Contributor

anushkafka commented Aug 9, 2022

From what I recall at the moment if internal configuration in ~/.npmrc overrides to artifactory there is no problem as artifactory is mirrored to npm as part of this work done here https://zendesk.atlassian.net/browse/ARTI-3

@token-cjg token-cjg merged commit 6b08316 into master Aug 9, 2022
@token-cjg token-cjg deleted the cgoddard/add-registry-option branch August 9, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants