From a9514ac461dd66f56f36a5be54cc33fda941f42a Mon Sep 17 00:00:00 2001 From: Christopher Goddard Date: Tue, 25 Jun 2024 12:03:14 +1000 Subject: [PATCH 1/2] Bump node from 14.17.3 to 20.13.1 Let's use an up to date version of nodejs that is currently LTS --- .github/workflows/test.yml | 2 +- .node-version | 2 +- .nvmrc | 2 +- README.md | 2 +- package.json | 2 +- packages/zcli/README.md | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b9e465e3..0f3e2b11 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -14,7 +14,7 @@ jobs: - ubuntu-latest - macos-latest - windows-latest - node-version: ["18.x"] + node-version: ["20.x"] runs-on: ${{ matrix.os }} steps: - uses: zendesk/checkout@v3 diff --git a/.node-version b/.node-version index a5e323ec..9bcccb94 100644 --- a/.node-version +++ b/.node-version @@ -1 +1 @@ -v14.17.3 +v20.13.1 diff --git a/.nvmrc b/.nvmrc index a5e323ec..9bcccb94 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v14.17.3 +v20.13.1 diff --git a/README.md b/README.md index bd53b107..4d7c0a10 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ For more about ZCLI see [the full documentation.](/docs) This is a [Node.js](https://nodejs.org/en/) module available through the [npm registry.](https://www.npmjs.com/package/@zendesk/zcli) -Before installing, download and install Node.js. Node.js 14.17.3 or higher is required. Installation is done using the `yarn` install command: +Before installing, download and install Node.js. Node.js 20.13.1 or higher is required. Installation is done using the `yarn` install command: ``` $ yarn global add @zendesk/zcli diff --git a/package.json b/package.json index 64583fc3..3470a548 100644 --- a/package.json +++ b/package.json @@ -36,7 +36,7 @@ "yarn-audit-fix": "^9.3.1" }, "engines": { - "node": ">=14.17.3" + "node": ">=20.13.1" }, "keywords": [ "zcli", diff --git a/packages/zcli/README.md b/packages/zcli/README.md index c0e0111e..e1a98315 100644 --- a/packages/zcli/README.md +++ b/packages/zcli/README.md @@ -4,7 +4,7 @@ $ yarn global add @zendesk/zcli $ zcli COMMAND running command... $ zcli --version -@zendesk/zcli/1.0.0-beta.23 darwin-x64 node-v14.17.3 +@zendesk/zcli/1.0.0-beta.23 darwin-x64 node-v20.13.1 $ zcli --help [COMMAND] USAGE $ zcli COMMAND From 5828f60fc953f62aae9d4284a620e9489f84c8c0 Mon Sep 17 00:00:00 2001 From: Christopher Goddard Date: Tue, 25 Jun 2024 13:10:14 +1000 Subject: [PATCH 2/2] Ensure that zcli supports nodejs 18.x while it is in maintenance mode - Node 18 will be in maintenance mode until May 2026 [1], therefore we should not drop support [1] https://endoflife.date/nodejs --- .github/workflows/test.yml | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 0f3e2b11..b9e465e3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -14,7 +14,7 @@ jobs: - ubuntu-latest - macos-latest - windows-latest - node-version: ["20.x"] + node-version: ["18.x"] runs-on: ${{ matrix.os }} steps: - uses: zendesk/checkout@v3 diff --git a/package.json b/package.json index 3470a548..593e61bd 100644 --- a/package.json +++ b/package.json @@ -36,7 +36,7 @@ "yarn-audit-fix": "^9.3.1" }, "engines": { - "node": ">=20.13.1" + "node": ">=18" }, "keywords": [ "zcli",