From 12a08ce1b801acb062231be2db158d8e51a9d40e Mon Sep 17 00:00:00 2001 From: Toan Nguyen Date: Fri, 6 Sep 2024 09:40:59 +1000 Subject: [PATCH] fix: module resolution (#262) --- packages/zcli-apps/package.json | 3 ++- packages/zcli-apps/src/commands/apps/update.ts | 4 ++-- yarn.lock | 10 ++++++++++ 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/packages/zcli-apps/package.json b/packages/zcli-apps/package.json index 0f154b04..672ecb3f 100644 --- a/packages/zcli-apps/package.json +++ b/packages/zcli-apps/package.json @@ -29,7 +29,8 @@ "rimraf": "^3.0.2", "semver": "^7.3.2", "tslib": "^2.4.0", - "uuid": "^8.3.2" + "uuid": "^8.3.2", + "@zendesk/zcli-core": "^1.0.0-beta.49" }, "devDependencies": { "@oclif/test": "=2.1.0", diff --git a/packages/zcli-apps/src/commands/apps/update.ts b/packages/zcli-apps/src/commands/apps/update.ts index 80862c1c..541e708f 100644 --- a/packages/zcli-apps/src/commands/apps/update.ts +++ b/packages/zcli-apps/src/commands/apps/update.ts @@ -8,7 +8,7 @@ import { getManifestFile } from '../../utils/manifest' import { createAppPkg } from '../../lib/package' import { Manifest, ZcliConfigFileContent } from '../../types' import { validateAppPath } from '../../lib/appPath' -import { EnvVars } from '@zendesk/zcli-core/src/lib/env' +import { env } from '@zendesk/zcli-core' export default class Update extends Command { static description = 'updates an existing private app in the Zendesk products specified in the apps manifest file.' @@ -20,7 +20,7 @@ export default class Update extends Command { static strict = false getAppID (appConfig: ZcliConfigFileContent) { - const app_id = process.env[EnvVars.APP_ID] || (appConfig ? appConfig.app_id : undefined) + const app_id = process.env[env.EnvVars.APP_ID] || (appConfig ? appConfig.app_id : undefined) if (!app_id) { throw new CLIError(chalk.red('App ID not found')) } return app_id } diff --git a/yarn.lock b/yarn.lock index 8d0c050c..394217b3 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1914,6 +1914,16 @@ resolved "https://registry.yarnpkg.com/@yarnpkg/lockfile/-/lockfile-1.1.0.tgz#e77a97fbd345b76d83245edcd17d393b1b41fb31" integrity sha512-GpSwvyXOcOOlV70vbnzjj4fW5xW/FdUF6nQEt1ENy7m4ZCczi1+/buVUPAqmGfqznsORNFzUMjctTIp8a9tuCQ== +"@zendesk/zcli-core@*": + version "1.0.0-beta.49" + dependencies: + "@oclif/plugin-plugins" "=2.1.12" + axios "^1.7.5" + chalk "^4.1.2" + fs-extra "^10.1.0" + optionalDependencies: + keytar "^7.9.0" + JSONStream@^1.0.4: version "1.3.5" resolved "https://registry.yarnpkg.com/JSONStream/-/JSONStream-1.3.5.tgz#3208c1f08d3a4d99261ab64f92302bc15e111ca0"