Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on React #11

Closed
Mando75 opened this issue Feb 22, 2022 · 1 comment · Fixed by #14
Closed

Remove dependency on React #11

Mando75 opened this issue Feb 22, 2022 · 1 comment · Fixed by #14

Comments

@Mando75
Copy link
Contributor

Mando75 commented Feb 22, 2022

Hi,

I am currently evaluating using Laika in our Vue/Nuxt application. As it stands, Laika has a transitive dependency on React via @apollo/client. I see you currently have this solved by including React as a dev dependency. However, this causes problems when trying to use Laika in a non-React application.

When we try to initialize the Laika link, we get a build error since Apollo cannot find the React dependency anywhere (See this GitHub issue for reference apollographql/apollo-client#8958). The solution to this would be to update the imports within Laika to use @apollo/client/core instead of @apollo/client (see this portion of the Apollo docs). This would also allow you to remove React dev dependency from Laika.

I have already forked Laika and made the required changes in a separate branch so I can continue my work, but I wanted to raise an issue as this may limit Laika's viability for non-React projects. I am more than happy to open that branch as a PR here if you would like to review the changes I made and potentially merge them into the main project.

@Mando75
Copy link
Contributor Author

Mando75 commented Mar 3, 2022

I went ahead and opened a PR to address this. See #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants