fix ambiguous abs() calls

[fxcoudert]

Compilation fails on macOS 10.12 and 10.13 with the latest system compilers (from Xcode 9), because of ambiguous calls to abs() with unsigned int arguments.

[zelurker]

Well this makes the code a lot less readable, but if it's really a problem for you... it really produces an error ? I really wouldn't want to program on osx these days then !
Anyway they are supposed to remove 32 bit support, in this case all this is useless...

[fxcoudert]

The code is, in my opinion, flawed anyway: unsigned int - int is promoted to unsigned int, and calling abs() on an unsigned int is… well, not defined.

[zelurker]

Oh well, if that's so important for you... for info with gcc-5.4.0 and -Wall this code does not produce any warning ! but anyway I'll accept it anyway...

[fxcoudert]

Thanks!

[zelurker]

On a side note I still don't see the problem here : abs takes an int as parameter, not an unsigned, that's all what matters here. And the internal representation of an int and an unsigned int is the same, so any operation on them produces the same result, it's just the interpretation of the most signifcant bit when printing which changes. so there was absolutely no problem here, except maybe for someone too used to c++ which is very tedious about type compatibility. You can make sure about all this by this simple program : #include <stdio.h> #include <stdlib.h> int main() { unsigned int a=4,b=5; printf("%d\n",abs(a-b)); return 0; } produces 1 of course, and without any warning. Anyway I accepted the patch, but it was really not necessary... ! 2017-10-06 13:17 GMT+02:00 FX Coudert <[email protected]>:

…

Thanks! — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACu5D1E9ww05Ch3OReC_9Ei2Alb67SYEks5spgxdgaJpZM4PvpGr> .

[fxcoudert]

Indeed in C it is no problem. But in C++ it is not allowed, as you stated. The files modified here are C++.

Thanks for merging the patch.