Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give extra vertical space to search result if it contains multiple linebreaks #114

Open
Thortok opened this issue Jul 8, 2023 · 2 comments

Comments

@Thortok
Copy link

Thortok commented Jul 8, 2023

As a way to make sure the right pin can be found if someone searches by quest name I included linebreaks in its name.

If it's the only search result it doesn't look too bad but if it shows up in a list with others then it does.

image

So far this is only done when quests are available simultaneously (and not sequentially) from the exact same questgiver/location. Sequential quests are stacked instead and given separate pins.

So far there's only 3 places this is done:

https://www.zeldadungeon.net/maps-beta/totk/?z=6&x=3144&y=367&l=Surface&m=SA-InvestigatetheThyphloRuins
https://www.zeldadungeon.net/maps-beta/totk/?z=6&x=-2157&y=3646&l=Surface&m=SA-Presenting
https://www.zeldadungeon.net/maps-beta/totk/?z=6&x=84&y=-285&l=Surface&m=SQ-WANTED

@LockeExile
Copy link
Contributor

I think these should be given separate stacked markers too, with maplinks to the other ones that can be done in parallel.

@Thortok
Copy link
Author

Thortok commented Oct 10, 2023

Then how do you decide which one appears by default? It's been a while but I remember people 'reporting' that stuff was 'missing' when we did it that way and it was because one pin was behind another. Sequential stuff didn't have that issue (or had it less often) because as soon as they mark the first complete there's the next. Those work really well actually.

If there was some way to mouseover and have them uncluster, but that'd be a lot of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants