Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that --fix is not executed #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Sep 14, 2018

fixes #23

The errors in the results of the formatFiles executed with the fix option seemed empty.
That is, I exit on line 68.
When there is a fix option, I fixed not to check error.

@zeke
Copy link
Owner

zeke commented Sep 14, 2018

Thanks @abetomo. I'm familiar with the --fix flag, but can you describe in more detail what this change is and how you expect it to work?

@abetomo
Copy link
Contributor Author

abetomo commented Sep 14, 2018

@zeke Thank you for review.

The errors in the results of the formatFiles executed with the fix option seemed empty.
That is, I exit on line 68.
When there is a fix option, I fixed not to check error.

@extremeheat
Copy link

Hi @zeke, do you have any objections to merging this PR? This is making it difficult to correct linting errors like in PrismarineJS/mineflayer#2374. It would be great if we could get this fix released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It doesn't --fix the: Missing space before function parentheses
3 participants