-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netlify cms example #8949
Merged
Merged
Netlify cms example #8949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
|
Timer
previously requested changes
Oct 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to land this if linting is fixed:
/home/circleci/repo/examples/netlifycms/components/layout/index.jsx:1:26: Extra semicolon.
/home/circleci/repo/examples/netlifycms/components/layout/index.jsx:2:29: Extra semicolon.
/home/circleci/repo/examples/netlifycms/components/layout/index.jsx:35:4: Extra semicolon.
/home/circleci/repo/examples/netlifycms/components/layout/index.jsx:36:2: Extra semicolon.
/home/circleci/repo/examples/netlifycms/components/layout/index.jsx:38:22: Extra semicolon.
/home/circleci/repo/examples/netlifycms/pages/blog/post/[slug].js:1:41: Extra semicolon.
/home/circleci/repo/examples/netlifycms/pages/blog/post/[slug].js:4:31: Missing space before function parentheses.
/home/circleci/repo/examples/netlifycms/pages/blog/post/[slug].js:5:27: Extra semicolon.
/home/circleci/repo/examples/netlifycms/pages/blog/post/[slug].js:6:82: Expected error to be handled.
/home/circleci/repo/examples/netlifycms/pages/blog/post/[slug].js:6:96: Extra semicolon.
/home/circleci/repo/examples/netlifycms/pages/blog/post/[slug].js:8:24: Extra semicolon.
/home/circleci/repo/examples/netlifycms/pages/blog/post/[slug].js:10:9: Missing space before function parentheses.
/home/circleci/repo/examples/netlifycms/pages/blog/post/[slug].js:11:58: Extra semicolon.
/home/circleci/repo/examples/netlifycms/pages/blog/post/[slug].js:15:39: Unexpected trailing comma.
/home/circleci/repo/examples/netlifycms/pages/blog/post/[slug].js:16:36: Extra semicolon.
/home/circleci/repo/examples/netlifycms/pages/blog/post/[slug].js:34:6: Extra semicolon.
/home/circleci/repo/examples/netlifycms/pages/blog/post/[slug].js:38:20: Extra semicolon.
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 89f3a6a |
lfades
dismissed
Timer’s stale review
October 19, 2019 23:46
I've updated most of the example, including the requested changes
lfades
approved these changes
Oct 19, 2019
rajendraarora16
added a commit
to rajendraarora16/next.js
that referenced
this pull request
Oct 20, 2019
Netlify cms example (vercel#8949)
This was referenced Nov 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created an example on how to use next.js with Netlify CMS (open source CMS for managing md files that are commited to github). Maybe it's worth adding to example list.
Netlify CMS creates md files for each blog post in content/blogPosts. We parse markdown with frontmatter in /pages/blog/post/[slug.js]. Also each post is created as separate static site. I'm happy to provide further explanation if necessary