Do not warn on valid AMP output #8924

jankarres · 2019-10-01T19:44:07Z

Actual:
Given we run next
Then we open http://localhost:3000/?amp=1 to render an AMP page
Then in packages/next/build/output/index.ts triggers line 176 to concat formatted error and warning messages of the AMP build process (formatAmpMessages())
Then formatAmpMessages() receives the following value as parameter amp, if / is an AMP page:

{
  '/': {
    errors: [
      {
       severity: 'ERROR',
       line: 1,
       col: 15,
       message:
        'Tag \'html\' marked with attribute \'data-ampdevmode\'. Validator will suppress errors regarding any other tag with this attribute.',
       specUrl: '',
       category: 'GENERIC',
       code: 'DEV_MODE_ONLY',
       params: []
      }
    ],
    warnings: []
  }
}

Then in formatAmpMessages() in packages/next/build/output/index.ts:95 filters the DEV_MODE_ONLY message, which causes that messages is an empty array
Then formatAmpMessages() returns an empty string
Then packages/next/build/output/index.ts triggers line 176 concats this empty string to the warnings
Then on the console a warning without text appears

Expected:
In this case of only have DEV_MODE_ONLY errors and warnings, which because an empty messages array, the method formatAmpMessages() should return some value, which is not handled by Array.concat() as a new value.

Resolution:
Return an empty array would be the only possible fix, because an empty array concated is no new element. It is no option to return undefined or null, because this comes a new element by Array.concat. But formatAmpMessages should have string as a return value.

For that reason I added a check, if the formatAmpMessages returns an empty string, before I push it. conact seems to be not an appropriated method to add a single string to a array

ijjk · 2019-10-01T19:50:00Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
buildDuration	16.1s	15.2s	-978ms
nodeModulesSize	48.2 MB	48.2 MB	⚠️ +176 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..2ca0edb75.js	43.2 kB	43.2 kB	✓
de003c3a9d30..db75.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
main-HASH.module.js	16.4 kB	16.4 kB	✓
main-HASH.module.js gzip	6.35 kB	6.35 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..c0.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	945 B	945 B	✓
link.html	3.66 kB	3.66 kB	✓
link.html gzip	953 B	953 B	✓
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	941 B	941 B	✓
Overall change	10.9 kB	10.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
buildDuration	15.5s	15.5s	-67ms
nodeModulesSize	48.2 MB	48.2 MB	⚠️ +176 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..2ca0edb75.js	43.2 kB	43.2 kB	✓
de003c3a9d30..db75.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
main-HASH.module.js	16.4 kB	16.4 kB	✓
main-HASH.module.js gzip	6.35 kB	6.35 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..c0.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_error.js	253 kB	253 kB	✓
_error.js gzip	67.9 kB	67.9 kB	✓
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	978 B	978 B	✓
index.js	254 kB	254 kB	✓
index.js gzip	68.2 kB	68.2 kB	✓
link.js	261 kB	261 kB	✓
link.js gzip	70.2 kB	70.2 kB	✓
routerDirect.js	255 kB	255 kB	✓
routerDirect.js gzip	68.3 kB	68.3 kB	✓
withRouter.js	255 kB	255 kB	✓
withRouter.js gzip	68.3 kB	68.3 kB	✓
Overall change	1.28 MB	1.28 MB	✓

Commit: 5581839

Timer

Can you please add a test case to prevent this from regressing?

jankarres · 2019-10-09T13:42:13Z

Thanks for your feedback @Timer!

I searched the code, but tests/ is the only folder where I could find tests. Unit tests seem to be the best way to test the described behaviour. However, I don't find any tests for packages/next/build/output/index.ts there.

Where can I find existing unit tests for the code so that I can extend the tests?

packages/next/build/output/index.ts

…uild process

Timer

Thanks!

…thout-message

ijjk · 2019-10-30T03:07:13Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
buildDuration	17.5s	17.8s	⚠️ +349ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +10 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.85 kB	5.85 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..63e75d588.js	19.7 kB	19.7 kB	✓
16b1a7225520..d588.js gzip	7.23 kB	7.23 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..51.module.js	15.8 kB	15.8 kB	✓
16b1a7225520..dule.js gzip	6.06 kB	6.06 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	199 B	199 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	210 B	210 B	✓
Overall change	495 B	495 B	✓

Rendered Page Sizes

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
index.html	3.94 kB	3.94 kB	✓
index.html gzip	1 kB	1 kB	✓
link.html	4.47 kB	4.47 kB	✓
link.html gzip	1.08 kB	1.08 kB	✓
withRouter.html	4.47 kB	4.47 kB	✓
withRouter.html gzip	1.07 kB	1.07 kB	✓
Overall change	12.9 kB	12.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
buildDuration	17.6s	17.5s	-116ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +10 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.85 kB	5.85 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..63e75d588.js	19.7 kB	19.7 kB	✓
16b1a7225520..d588.js gzip	7.23 kB	7.23 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..51.module.js	15.8 kB	15.8 kB	✓
16b1a7225520..dule.js gzip	6.06 kB	6.06 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	199 B	199 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	210 B	210 B	✓
Overall change	495 B	495 B	✓

Serverless bundles

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_error.js	241 kB	241 kB	✓
_error.js gzip	64.4 kB	64.4 kB	✓
hooks.html	4.08 kB	4.08 kB	✓
hooks.html gzip	1.03 kB	1.03 kB	✓
index.js	241 kB	241 kB	✓
index.js gzip	64.5 kB	64.5 kB	✓
link.js	274 kB	274 kB	✓
link.js gzip	73.5 kB	73.5 kB	✓
routerDirect.js	267 kB	267 kB	✓
routerDirect.js gzip	71.5 kB	71.5 kB	✓
withRouter.js	267 kB	267 kB	✓
withRouter.js gzip	71.6 kB	71.6 kB	✓
Overall change	1.29 MB	1.29 MB	✓

Commit: 1b08585

This adds a test for PR vercel#8924.

…thout-message

ijjk · 2019-10-30T03:27:15Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
buildDuration	15.2s	15.4s	⚠️ +221ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +10 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.85 kB	5.85 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..63e75d588.js	19.7 kB	19.7 kB	✓
16b1a7225520..d588.js gzip	7.23 kB	7.23 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..51.module.js	15.8 kB	15.8 kB	✓
16b1a7225520..dule.js gzip	6.06 kB	6.06 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	199 B	199 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	210 B	210 B	✓
Overall change	495 B	495 B	✓

Rendered Page Sizes

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
index.html	3.94 kB	3.94 kB	✓
index.html gzip	1 kB	1 kB	✓
link.html	4.47 kB	4.47 kB	✓
link.html gzip	1.08 kB	1.08 kB	✓
withRouter.html	4.47 kB	4.47 kB	✓
withRouter.html gzip	1.07 kB	1.07 kB	✓
Overall change	12.9 kB	12.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
buildDuration	15.3s	15.5s	⚠️ +203ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +10 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.85 kB	5.85 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..63e75d588.js	19.7 kB	19.7 kB	✓
16b1a7225520..d588.js gzip	7.23 kB	7.23 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..51.module.js	15.8 kB	15.8 kB	✓
16b1a7225520..dule.js gzip	6.06 kB	6.06 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	199 B	199 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	210 B	210 B	✓
Overall change	495 B	495 B	✓

Serverless bundles

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_error.js	241 kB	241 kB	✓
_error.js gzip	64.4 kB	64.4 kB	✓
hooks.html	4.08 kB	4.08 kB	✓
hooks.html gzip	1.03 kB	1.03 kB	✓
index.js	241 kB	241 kB	✓
index.js gzip	64.5 kB	64.5 kB	✓
link.js	274 kB	274 kB	✓
link.js gzip	73.5 kB	73.5 kB	✓
routerDirect.js	267 kB	267 kB	✓
routerDirect.js gzip	71.5 kB	71.5 kB	✓
withRouter.js	267 kB	267 kB	✓
withRouter.js gzip	71.6 kB	71.6 kB	✓
Overall change	1.29 MB	1.29 MB	✓

Commit: fc4e2da

…thout-message

ijjk · 2019-10-30T03:42:44Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
buildDuration	16.5s	16.4s	-99ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +10 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.85 kB	5.85 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..63e75d588.js	19.7 kB	19.7 kB	✓
16b1a7225520..d588.js gzip	7.23 kB	7.23 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..51.module.js	15.8 kB	15.8 kB	✓
16b1a7225520..dule.js gzip	6.06 kB	6.06 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	199 B	199 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	210 B	210 B	✓
Overall change	495 B	495 B	✓

Rendered Page Sizes

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
index.html	3.94 kB	3.94 kB	✓
index.html gzip	1 kB	1 kB	✓
link.html	4.47 kB	4.47 kB	✓
link.html gzip	1.08 kB	1.08 kB	✓
withRouter.html	4.47 kB	4.47 kB	✓
withRouter.html gzip	1.07 kB	1.07 kB	✓
Overall change	12.9 kB	12.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
buildDuration	15.9s	16.2s	⚠️ +263ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +10 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.85 kB	5.85 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..63e75d588.js	19.7 kB	19.7 kB	✓
16b1a7225520..d588.js gzip	7.23 kB	7.23 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
main-HASH.module.js	14 kB	14 kB	✓
main-HASH.module.js gzip	5.25 kB	5.25 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..51.module.js	15.8 kB	15.8 kB	✓
16b1a7225520..dule.js gzip	6.06 kB	6.06 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	199 B	199 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	210 B	210 B	✓
Overall change	495 B	495 B	✓

Serverless bundles

	zeit/next.js canary	jankarres/next.js fix/next/build-output-formatAmpMessages-without-message	Change
_error.js	241 kB	241 kB	✓
_error.js gzip	64.4 kB	64.4 kB	✓
hooks.html	4.08 kB	4.08 kB	✓
hooks.html gzip	1.03 kB	1.03 kB	✓
index.js	241 kB	241 kB	✓
index.js gzip	64.5 kB	64.5 kB	✓
link.js	274 kB	274 kB	✓
link.js gzip	73.5 kB	73.5 kB	✓
routerDirect.js	267 kB	267 kB	✓
routerDirect.js gzip	71.5 kB	71.5 kB	✓
withRouter.js	267 kB	267 kB	✓
withRouter.js gzip	71.6 kB	71.6 kB	✓
Overall change	1.29 MB	1.29 MB	✓

Commit: d3725a3

This adds a test for PR #8924.

jankarres requested review from ijjk, lfades, Timer and timneutkens as code owners October 1, 2019 19:44

Timer requested changes Oct 2, 2019

View reviewed changes

jankarres requested a review from Timer October 14, 2019 16:02

lfades reviewed Oct 22, 2019

View reviewed changes

packages/next/build/output/index.ts Outdated Show resolved Hide resolved

Check if 'formatAmpMessages' returns a none empty string in Next.js b…

c37ba81

…uild process

jankarres force-pushed the fix/next/build-output-formatAmpMessages-without-message branch from 5581839 to c37ba81 Compare October 23, 2019 13:55

jankarres requested a review from lfades October 23, 2019 13:55

Timer changed the title ~~Fix missing check if 'formatAmpMessages' returns a none empty string Check if 'formatAmpMessages' returns a none empty string in Next.js build process~~ Do not warn on valid AMP output Oct 30, 2019

Timer added priority: low labels Oct 30, 2019

Timer added this to the 9.1.3 milestone Oct 30, 2019

Timer approved these changes Oct 30, 2019

View reviewed changes

Merge branch 'canary' into fix/next/build-output-formatAmpMessages-wi…

1b08585

…thout-message

Timer added a commit to Timer/next.js that referenced this pull request Oct 30, 2019

Add test for vercel#8924

1f6895e

This adds a test for PR vercel#8924.

Timer mentioned this pull request Oct 30, 2019

Add test for #8924 #9243

Merged

Timer added 2 commits October 29, 2019 23:08

Merge branch 'canary' into fix/next/build-output-formatAmpMessages-wi…

f96f67f

…thout-message

Merge branch 'canary' into fix/next/build-output-formatAmpMessages-wi…

fc4e2da

…thout-message

Merge branch 'canary' into fix/next/build-output-formatAmpMessages-wi…

d3725a3

…thout-message

Timer merged commit 3b3d20f into vercel:canary Oct 30, 2019

Timer added a commit that referenced this pull request Oct 30, 2019

Add test for #8924 (#9243)

636be24

This adds a test for PR #8924.

snyk-bot mentioned this pull request Nov 19, 2019

[Snyk] Upgrade next from 9.1.2 to 9.1.3 ndom91/newtelco-next-maintenance-mgmt#10

Merged

snyk-bot mentioned this pull request Nov 25, 2019

[Snyk] Upgrade next from 9.0.4 to 9.1.3 ajesse11x/now-examples#17

Open

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not warn on valid AMP output #8924

Do not warn on valid AMP output #8924

jankarres commented Oct 1, 2019 •

edited

Loading

ijjk commented Oct 1, 2019

Timer left a comment

jankarres commented Oct 9, 2019

Timer left a comment

ijjk commented Oct 30, 2019

ijjk commented Oct 30, 2019

ijjk commented Oct 30, 2019

Do not warn on valid AMP output #8924

Do not warn on valid AMP output #8924

Conversation

jankarres commented Oct 1, 2019 • edited Loading

ijjk commented Oct 1, 2019

Stats from current PR

Timer left a comment

Choose a reason for hiding this comment

jankarres commented Oct 9, 2019

Timer left a comment

Choose a reason for hiding this comment

ijjk commented Oct 30, 2019

Stats from current PR

ijjk commented Oct 30, 2019

Stats from current PR

ijjk commented Oct 30, 2019

Stats from current PR

jankarres commented Oct 1, 2019 •

edited

Loading