Fix ncc'd version of terser not being used by terser webpack plugin #12252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server Mode (Increase detected
|
| zeit/next.js canary | ijjk/next.js fix/terser-require | Change | |
|---|---|---|---|
| buildDuration | 12.6s | 12.8s | |
| nodeModulesSize | 55.2 MB | 55.2 MB |
Page Load Tests Overall increase ✓
| zeit/next.js canary | ijjk/next.js fix/terser-require | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.225 | 2.219 | -0.01 |
| / avg req/sec | 1123.79 | 1126.76 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.272 | 1.22 | -0.05 |
| /error-in-render avg req/sec | 1964.9 | 2049.88 |
Client Bundles (main, webpack, commons) Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js fix/terser-require | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.27 kB | 6.27 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..ac5e.js gzip | 10.3 kB | 10.3 kB | -5 B |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.HASH.js gzip | 39 kB | 39.2 kB | |
| Overall change | 56.8 kB | 56.9 kB |
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js fix/terser-require | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.82 kB | 4.82 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.88 kB | 6.88 kB | ✓ |
| framework.HA..dule.js gzip | 39 kB | 39.2 kB | |
| Overall change | 51.5 kB | 51.7 kB |
Legacy Client Bundles (polyfills) Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js fix/terser-require | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.2 kB | 26.3 kB | |
| Overall change | 26.2 kB | 26.3 kB |
Client Pages Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js fix/terser-require | Change | |
|---|---|---|---|
| _app.js gzip | 1.23 kB | 1.23 kB | ✓ |
| _error.js gzip | 3.12 kB | 3.15 kB | |
| hooks.js gzip | 663 B | 663 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.06 kB | 2.06 kB | -4 B |
| routerDirect.js gzip | 280 B | 280 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.85 kB | 7.88 kB |
Client Pages Modern Overall decrease ✓
| zeit/next.js canary | ijjk/next.js fix/terser-require | Change | |
|---|---|---|---|
| _app.module.js gzip | 598 B | 598 B | ✓ |
| _error.module.js gzip | 2.09 kB | 2.09 kB | ✓ |
| hooks.module.js gzip | 383 B | 383 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js gzip | 1.52 kB | 1.52 kB | -4 B |
| routerDirect..dule.js gzip | 279 B | 279 B | ✓ |
| withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
| Overall change | 5.37 kB | 5.37 kB | -4 B |
Client Build Manifests
| zeit/next.js canary | ijjk/next.js fix/terser-require | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
| zeit/next.js canary | ijjk/next.js fix/terser-require | Change | |
|---|---|---|---|
| index.html gzip | 927 B | 927 B | ✓ |
| link.html gzip | 937 B | 937 B | ✓ |
| withRouter.html gzip | 926 B | 926 B | ✓ |
| Overall change | 2.79 kB | 2.79 kB | ✓ |
Serverless Mode (Increase detected ⚠️ )
General Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js fix/terser-require | Change | |
|---|---|---|---|
| buildDuration | 13.5s | 13.4s | -95ms |
| nodeModulesSize | 55.2 MB | 55.2 MB |
Client Bundles (main, webpack, commons) Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js fix/terser-require | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.27 kB | 6.27 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..ac5e.js gzip | 10.3 kB | 10.3 kB | -5 B |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.HASH.js gzip | 39 kB | 39.2 kB | |
| Overall change | 56.8 kB | 56.9 kB |
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js fix/terser-require | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.82 kB | 4.82 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.88 kB | 6.88 kB | ✓ |
| framework.HA..dule.js gzip | 39 kB | 39.2 kB | |
| Overall change | 51.5 kB | 51.7 kB |
Legacy Client Bundles (polyfills) Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js fix/terser-require | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.2 kB | 26.3 kB | |
| Overall change | 26.2 kB | 26.3 kB |
Client Pages Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js fix/terser-require | Change | |
|---|---|---|---|
| _app.js gzip | 1.23 kB | 1.23 kB | ✓ |
| _error.js gzip | 3.12 kB | 3.15 kB | |
| hooks.js gzip | 663 B | 663 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.06 kB | 2.06 kB | -4 B |
| routerDirect.js gzip | 280 B | 280 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.85 kB | 7.88 kB |
Client Pages Modern Overall decrease ✓
| zeit/next.js canary | ijjk/next.js fix/terser-require | Change | |
|---|---|---|---|
| _app.module.js gzip | 598 B | 598 B | ✓ |
| _error.module.js gzip | 2.09 kB | 2.09 kB | ✓ |
| hooks.module.js gzip | 383 B | 383 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js gzip | 1.52 kB | 1.52 kB | -4 B |
| routerDirect..dule.js gzip | 279 B | 279 B | ✓ |
| withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
| Overall change | 5.37 kB | 5.37 kB | -4 B |
Client Build Manifests
| zeit/next.js canary | ijjk/next.js fix/terser-require | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles
| zeit/next.js canary | ijjk/next.js fix/terser-require | Change | |
|---|---|---|---|
| _error.js | 558 kB | 558 kB | ✓ |
| 404.html | 4.18 kB | 4.18 kB | ✓ |
| hooks.html | 3.81 kB | 3.81 kB | ✓ |
| index.js | 558 kB | 558 kB | ✓ |
| link.js | 595 kB | 595 kB | ✓ |
| routerDirect.js | 587 kB | 587 kB | ✓ |
| withRouter.js | 587 kB | 587 kB | ✓ |
| Overall change | 2.89 MB | 2.89 MB | ✓ |
timneutkens
approved these changes
Apr 28, 2020
This was referenced May 1, 2020
rokinsky
pushed a commit
to rokinsky/next.js
that referenced
this pull request
Jul 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that the
terserrequire interser-webpack-plugin'sworker.jsasset file gets updated to the correctexternalsoutput path so that our ncc'd version ofterseris used and not the closest installed versionx-ref: #12178