refactor(next-client-pages-loader): allow toggling router HMR #11989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server Mode (Increase detected
|
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| buildDuration | 11s | 11.1s | |
| nodeModulesSize | 55.5 MB | 55.5 MB |
Page Load Tests Overall increase ✓
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 1.809 | 1.81 | 0 |
| / avg req/sec | 1382.04 | 1381.07 | -0.97 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 0.948 | 0.914 | -0.03 |
| /error-in-render avg req/sec | 2638.1 | 2734.37 |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.25 kB | 6.25 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..5e5e.js gzip | 10.3 kB | 10.3 kB | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| Overall change | 56.7 kB | 56.7 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.79 kB | 4.79 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.85 kB | 6.85 kB | ✓ |
| framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
| Overall change | 51.4 kB | 51.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.2 kB | 26.2 kB | ✓ |
| Overall change | 26.2 kB | 26.2 kB | ✓ |
Client Pages Overall decrease ✓
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.23 kB | -4 B |
| _error.js gzip | 3.12 kB | 3.12 kB | |
| hooks.js gzip | 664 B | 663 B | -1 B |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.06 kB | 2.06 kB | ✓ |
| routerDirect.js gzip | 279 B | 280 B | |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.85 kB | -2 B |
Client Pages Modern Overall decrease ✓
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _app.module.js gzip | 602 B | 598 B | -4 B |
| _error.module.js gzip | 2.09 kB | 2.09 kB | |
| hooks.module.js gzip | 383 B | 383 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js gzip | 1.52 kB | 1.52 kB | -1 B |
| routerDirect..dule.js gzip | 281 B | 279 B | -2 B |
| withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
| Overall change | 5.38 kB | 5.37 kB | -2 B |
Client Build Manifests
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| index.html gzip | 927 B | 927 B | ✓ |
| link.html gzip | 937 B | 937 B | ✓ |
| withRouter.html gzip | 924 B | 924 B | ✓ |
| Overall change | 2.79 kB | 2.79 kB | ✓ |
Diffs
Diff for _app.js
@@ -1,9 +1,25 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+/***/ "++dY":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/_app",
+ function () {
+ var mod = __webpack_require__("B5Ud");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
+/***/ }),
+
/***/ 0:
/***/ (function(module, exports, __webpack_require__) {
-__webpack_require__("e9+W");
+__webpack_require__("++dY");
module.exports = __webpack_require__("nOHt");
@@ -245,19 +261,6 @@ function _possibleConstructorReturn(self, call) {
module.exports = _possibleConstructorReturn;
-/***/ }),
-
-/***/ "e9+W":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/_app", function() {
- var mod = __webpack_require__("B5Ud")
- if(false) {}
- return mod
- }]);
-
-
/***/ })
},[[0,0,1,2]]]);
\ No newline at end of fileDiff for _app.module.js
@@ -1,9 +1,25 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+/***/ "++dY":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/_app",
+ function () {
+ var mod = __webpack_require__("B5Ud");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
+/***/ }),
+
/***/ 0:
/***/ (function(module, exports, __webpack_require__) {
-__webpack_require__("e9+W");
+__webpack_require__("++dY");
module.exports = __webpack_require__("nOHt");
@@ -132,19 +148,6 @@ function createUrl(router) {
};
}
-/***/ }),
-
-/***/ "e9+W":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/_app", function() {
- var mod = __webpack_require__("B5Ud")
- if(false) {}
- return mod
- }]);
-
-
/***/ })
},[[0,0,1,2]]]);
\ No newline at end of fileDiff for _error.js
@@ -169,19 +169,6 @@ var styles = {
}
};
-/***/ }),
-
-/***/ "04ac":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/_error", function() {
- var mod = __webpack_require__("/a9y")
- if(false) {}
- return mod
- }]);
-
-
/***/ }),
/***/ "7W2i":
@@ -740,6 +727,22 @@ function _classCallCheck(instance, Constructor) {
module.exports = _classCallCheck;
+/***/ }),
+
+/***/ "nHv3":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/_error",
+ function () {
+ var mod = __webpack_require__("/a9y");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ })
-},[["04ac",0,1]]]);
\ No newline at end of file
+},[["nHv3",0,1]]]);
\ No newline at end of fileDiff for _error.module.js
@@ -142,19 +142,6 @@ var styles = {
}
};
-/***/ }),
-
-/***/ "04ac":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/_error", function() {
- var mod = __webpack_require__("/a9y")
- if(false) {}
- return mod
- }]);
-
-
/***/ }),
/***/ "8Kt/":
@@ -470,6 +457,22 @@ exports.AmpStateContext = React.createContext({});
if (false) {}
+/***/ }),
+
+/***/ "nHv3":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/_error",
+ function () {
+ var mod = __webpack_require__("/a9y");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ })
-},[["04ac",0,1]]]);
\ No newline at end of file
+},[["nHv3",0,1]]]);
\ No newline at end of fileDiff for hooks.js
@@ -93,17 +93,20 @@ var assign=Object.assign.bind(Object);module.exports=assign;module.exports.defau
/***/ }),
-/***/ "g1vQ":
+/***/ "plgv":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/hooks", function() {
- var mod = __webpack_require__("+MDD")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/hooks",
+ function () {
+ var mod = __webpack_require__("+MDD");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["g1vQ",0,1]]]);
\ No newline at end of file
+},[["plgv",0,1]]]);
\ No newline at end of fileDiff for hooks.module.js
@@ -38,17 +38,20 @@ var assign=Object.assign.bind(Object);module.exports=assign;module.exports.defau
/***/ }),
-/***/ "g1vQ":
+/***/ "plgv":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/hooks", function() {
- var mod = __webpack_require__("+MDD")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/hooks",
+ function () {
+ var mod = __webpack_require__("+MDD");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["g1vQ",0,1]]]);
\ No newline at end of file
+},[["plgv",0,1]]]);
\ No newline at end of fileDiff for index.js
@@ -17,17 +17,20 @@ Page.getInitialProps = function () {
/***/ }),
-/***/ "vlRD":
+/***/ "m0L+":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/", function() {
- var mod = __webpack_require__("RNiq")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/",
+ function () {
+ var mod = __webpack_require__("RNiq");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["vlRD",0]]]);
\ No newline at end of file
+},[["m0L+",0]]]);
\ No newline at end of fileDiff for index.module.js
@@ -13,17 +13,20 @@ Page.getInitialProps = () => ({});
/***/ }),
-/***/ "vlRD":
+/***/ "m0L+":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/", function() {
- var mod = __webpack_require__("RNiq")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/",
+ function () {
+ var mod = __webpack_require__("RNiq");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["vlRD",0]]]);
\ No newline at end of file
+},[["m0L+",0]]]);
\ No newline at end of fileDiff for link.js
@@ -22,6 +22,22 @@ function _inherits(subClass, superClass) {
module.exports = _inherits;
+/***/ }),
+
+/***/ "GwDo":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/link",
+ function () {
+ var mod = __webpack_require__("ObF3");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ }),
/***/ "Nsbk":
@@ -78,19 +94,6 @@ function _assertThisInitialized(self) {
module.exports = _assertThisInitialized;
-/***/ }),
-
-/***/ "V8Sf":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/link", function() {
- var mod = __webpack_require__("ObF3")
- if(false) {}
- return mod
- }]);
-
-
/***/ }),
/***/ "YFqc":
@@ -438,4 +441,4 @@ exports["default"] = _default;
/***/ })
-},[["V8Sf",0,1,2]]]);
\ No newline at end of file
+},[["GwDo",0,1,2]]]);
\ No newline at end of fileDiff for link.module.js
@@ -1,5 +1,21 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+/***/ "GwDo":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/link",
+ function () {
+ var mod = __webpack_require__("ObF3");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
+/***/ }),
+
/***/ "ObF3":
/***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -23,19 +39,6 @@ aLink.getInitialProps = () => ({});
/* harmony default export */ __webpack_exports__["default"] = (aLink);
-/***/ }),
-
-/***/ "V8Sf":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/link", function() {
- var mod = __webpack_require__("ObF3")
- if(false) {}
- return mod
- }]);
-
-
/***/ }),
/***/ "YFqc":
@@ -337,4 +340,4 @@ exports.default = _default;
/***/ })
-},[["V8Sf",0,1,2]]]);
\ No newline at end of file
+},[["GwDo",0,1,2]]]);
\ No newline at end of fileDiff for routerDirect.js
@@ -1,18 +1,5 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
-/***/ "LtRI":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/routerDirect", function() {
- var mod = __webpack_require__("jSAA")
- if(false) {}
- return mod
- }]);
-
-
-/***/ }),
-
/***/ "jSAA":
/***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -38,6 +25,22 @@ routerDirect.getInitialProps = function () {
/* harmony default export */ __webpack_exports__["default"] = (routerDirect);
+/***/ }),
+
+/***/ "ksEn":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/routerDirect",
+ function () {
+ var mod = __webpack_require__("jSAA");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ })
-},[["LtRI",0,1,2]]]);
\ No newline at end of file
+},[["ksEn",0,1,2]]]);
\ No newline at end of fileDiff for routerDirect.module.js
@@ -1,18 +1,5 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
-/***/ "LtRI":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/routerDirect", function() {
- var mod = __webpack_require__("jSAA")
- if(false) {}
- return mod
- }]);
-
-
-/***/ }),
-
/***/ "jSAA":
/***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -36,6 +23,22 @@ routerDirect.getInitialProps = () => ({});
/* harmony default export */ __webpack_exports__["default"] = (routerDirect);
+/***/ }),
+
+/***/ "ksEn":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/routerDirect",
+ function () {
+ var mod = __webpack_require__("jSAA");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ })
-},[["LtRI",0,1,2]]]);
\ No newline at end of file
+},[["ksEn",0,1,2]]]);
\ No newline at end of fileDiff for withRouter.js
@@ -25,17 +25,20 @@ useWithRouter.getInitialProps = function () {
/***/ }),
-/***/ "eThv":
+/***/ "eqah":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/withRouter", function() {
- var mod = __webpack_require__("0Hlz")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/withRouter",
+ function () {
+ var mod = __webpack_require__("0Hlz");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["eThv",0,1,2]]]);
\ No newline at end of file
+},[["eqah",0,1,2]]]);
\ No newline at end of fileDiff for withRouter.module.js
@@ -23,17 +23,20 @@ useWithRouter.getInitialProps = () => ({});
/***/ }),
-/***/ "eThv":
+/***/ "eqah":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/withRouter", function() {
- var mod = __webpack_require__("0Hlz")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/withRouter",
+ function () {
+ var mod = __webpack_require__("0Hlz");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["eThv",0,1,2]]]);
\ No newline at end of file
+},[["eqah",0,1,2]]]);
\ No newline at end of fileServerless Mode (Decrease detected ✓)
General Overall increase ⚠️
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| buildDuration | 11.9s | 12s | |
| nodeModulesSize | 55.5 MB | 55.5 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.25 kB | 6.25 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..5e5e.js gzip | 10.3 kB | 10.3 kB | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| Overall change | 56.7 kB | 56.7 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.79 kB | 4.79 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.85 kB | 6.85 kB | ✓ |
| framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
| Overall change | 51.4 kB | 51.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.2 kB | 26.2 kB | ✓ |
| Overall change | 26.2 kB | 26.2 kB | ✓ |
Client Pages Overall decrease ✓
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.23 kB | -4 B |
| _error.js gzip | 3.12 kB | 3.12 kB | |
| hooks.js gzip | 664 B | 663 B | -1 B |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.06 kB | 2.06 kB | ✓ |
| routerDirect.js gzip | 279 B | 280 B | |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.85 kB | -2 B |
Client Pages Modern Overall decrease ✓
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _app.module.js gzip | 602 B | 598 B | -4 B |
| _error.module.js gzip | 2.09 kB | 2.09 kB | |
| hooks.module.js gzip | 383 B | 383 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js gzip | 1.52 kB | 1.52 kB | -1 B |
| routerDirect..dule.js gzip | 281 B | 279 B | -2 B |
| withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
| Overall change | 5.38 kB | 5.37 kB | -2 B |
Client Build Manifests
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _error.js | 558 kB | 558 kB | ✓ |
| 404.html | 4.18 kB | 4.18 kB | ✓ |
| hooks.html | 3.81 kB | 3.81 kB | ✓ |
| index.js | 558 kB | 558 kB | ✓ |
| link.js | 594 kB | 594 kB | ✓ |
| routerDirect.js | 587 kB | 587 kB | ✓ |
| withRouter.js | 587 kB | 587 kB | ✓ |
| Overall change | 2.89 MB | 2.89 MB | ✓ |
Failing test suitestest/integration/production-config/test/index.test.js
Expand output● Production Config Usage › with generateBuildId › should add the custom buildid |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| buildDuration | 12.3s | 12.4s | |
| nodeModulesSize | 55.5 MB | 55.5 MB |
Page Load Tests Overall decrease ⚠️
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.176 | 2.134 | -0.04 |
| / avg req/sec | 1148.88 | 1171.54 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.186 | 1.225 | |
| /error-in-render avg req/sec | 2107.88 | 2041.19 | -66.69 |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.25 kB | 6.25 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..5e5e.js gzip | 10.3 kB | 10.3 kB | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| Overall change | 56.7 kB | 56.7 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.79 kB | 4.79 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.85 kB | 6.85 kB | ✓ |
| framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
| Overall change | 51.4 kB | 51.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.2 kB | 26.2 kB | ✓ |
| Overall change | 26.2 kB | 26.2 kB | ✓ |
Client Pages
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.24 kB | |
| _error.js gzip | 3.12 kB | 3.12 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.06 kB | 2.06 kB | -3 B |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 279 B | |
| Overall change | 7.86 kB | 7.86 kB | ✓ |
Client Pages Modern Overall increase ⚠️
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _app.module.js gzip | 602 B | 603 B | |
| _error.module.js gzip | 2.09 kB | 2.09 kB | |
| hooks.module.js gzip | 383 B | 383 B | ✓ |
| index.module.js gzip | 223 B | 222 B | -1 B |
| link.module.js gzip | 1.52 kB | 1.52 kB | -1 B |
| routerDirect..dule.js gzip | 281 B | 280 B | -1 B |
| withRouter.m..dule.js gzip | 278 B | 279 B | |
| Overall change | 5.38 kB | 5.38 kB |
Client Build Manifests
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| index.html gzip | 927 B | 927 B | ✓ |
| link.html gzip | 937 B | 937 B | ✓ |
| withRouter.html gzip | 924 B | 924 B | ✓ |
| Overall change | 2.79 kB | 2.79 kB | ✓ |
Diffs
Diff for _app.js
@@ -3,7 +3,7 @@
/***/ 0:
/***/ (function(module, exports, __webpack_require__) {
-__webpack_require__("e9+W");
+__webpack_require__("KVFN");
module.exports = __webpack_require__("nOHt");
@@ -197,6 +197,22 @@ function createUrl(router) {
};
}
+/***/ }),
+
+/***/ "KVFN":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/_app",
+ function () {
+ var mod = __webpack_require__("B5Ud");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ }),
/***/ "Nsbk":
@@ -245,19 +261,6 @@ function _possibleConstructorReturn(self, call) {
module.exports = _possibleConstructorReturn;
-/***/ }),
-
-/***/ "e9+W":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/_app", function() {
- var mod = __webpack_require__("B5Ud")
- if(false) {}
- return mod
- }]);
-
-
/***/ })
},[[0,0,1,2]]]);
\ No newline at end of fileDiff for _app.module.js
@@ -3,7 +3,7 @@
/***/ 0:
/***/ (function(module, exports, __webpack_require__) {
-__webpack_require__("e9+W");
+__webpack_require__("KVFN");
module.exports = __webpack_require__("nOHt");
@@ -134,15 +134,18 @@ function createUrl(router) {
/***/ }),
-/***/ "e9+W":
+/***/ "KVFN":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/_app", function() {
- var mod = __webpack_require__("B5Ud")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/_app",
+ function () {
+ var mod = __webpack_require__("B5Ud");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })Diff for _error.js
@@ -169,19 +169,6 @@ var styles = {
}
};
-/***/ }),
-
-/***/ "04ac":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/_error", function() {
- var mod = __webpack_require__("/a9y")
- if(false) {}
- return mod
- }]);
-
-
/***/ }),
/***/ "7W2i":
@@ -699,6 +686,22 @@ function _typeof(obj) {
module.exports = _typeof;
+/***/ }),
+
+/***/ "cnfB":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/_error",
+ function () {
+ var mod = __webpack_require__("/a9y");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ }),
/***/ "lwAK":
@@ -742,4 +745,4 @@ module.exports = _classCallCheck;
/***/ })
-},[["04ac",0,1]]]);
\ No newline at end of file
+},[["cnfB",0,1]]]);
\ No newline at end of fileDiff for _error.module.js
@@ -142,19 +142,6 @@ var styles = {
}
};
-/***/ }),
-
-/***/ "04ac":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/_error", function() {
- var mod = __webpack_require__("/a9y")
- if(false) {}
- return mod
- }]);
-
-
/***/ }),
/***/ "8Kt/":
@@ -442,6 +429,22 @@ exports.default = () => {
};
};
+/***/ }),
+
+/***/ "cnfB":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/_error",
+ function () {
+ var mod = __webpack_require__("/a9y");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ }),
/***/ "lwAK":
@@ -472,4 +475,4 @@ if (false) {}
/***/ })
-},[["04ac",0,1]]]);
\ No newline at end of file
+},[["cnfB",0,1]]]);
\ No newline at end of fileDiff for hooks.js
@@ -93,17 +93,20 @@ var assign=Object.assign.bind(Object);module.exports=assign;module.exports.defau
/***/ }),
-/***/ "g1vQ":
+/***/ "ZppN":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/hooks", function() {
- var mod = __webpack_require__("+MDD")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/hooks",
+ function () {
+ var mod = __webpack_require__("+MDD");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["g1vQ",0,1]]]);
\ No newline at end of file
+},[["ZppN",0,1]]]);
\ No newline at end of fileDiff for hooks.module.js
@@ -38,17 +38,20 @@ var assign=Object.assign.bind(Object);module.exports=assign;module.exports.defau
/***/ }),
-/***/ "g1vQ":
+/***/ "ZppN":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/hooks", function() {
- var mod = __webpack_require__("+MDD")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/hooks",
+ function () {
+ var mod = __webpack_require__("+MDD");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["g1vQ",0,1]]]);
\ No newline at end of file
+},[["ZppN",0,1]]]);
\ No newline at end of fileDiff for index.js
@@ -1,5 +1,21 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+/***/ "0D0J":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/",
+ function () {
+ var mod = __webpack_require__("RNiq");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
+/***/ }),
+
/***/ "RNiq":
/***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -15,19 +31,6 @@ Page.getInitialProps = function () {
/* harmony default export */ __webpack_exports__["default"] = (Page);
-/***/ }),
-
-/***/ "vlRD":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/", function() {
- var mod = __webpack_require__("RNiq")
- if(false) {}
- return mod
- }]);
-
-
/***/ })
-},[["vlRD",0]]]);
\ No newline at end of file
+},[["0D0J",0]]]);
\ No newline at end of fileDiff for index.module.js
@@ -1,5 +1,21 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+/***/ "0D0J":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/",
+ function () {
+ var mod = __webpack_require__("RNiq");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
+/***/ }),
+
/***/ "RNiq":
/***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -11,19 +27,6 @@ Page.getInitialProps = () => ({});
/* harmony default export */ __webpack_exports__["default"] = (Page);
-/***/ }),
-
-/***/ "vlRD":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/", function() {
- var mod = __webpack_require__("RNiq")
- if(false) {}
- return mod
- }]);
-
-
/***/ })
-},[["vlRD",0]]]);
\ No newline at end of file
+},[["0D0J",0]]]);
\ No newline at end of fileDiff for link.js
@@ -1,5 +1,21 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+/***/ "0Mts":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/link",
+ function () {
+ var mod = __webpack_require__("ObF3");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
+/***/ }),
+
/***/ "7W2i":
/***/ (function(module, exports, __webpack_require__) {
@@ -78,19 +94,6 @@ function _assertThisInitialized(self) {
module.exports = _assertThisInitialized;
-/***/ }),
-
-/***/ "V8Sf":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/link", function() {
- var mod = __webpack_require__("ObF3")
- if(false) {}
- return mod
- }]);
-
-
/***/ }),
/***/ "YFqc":
@@ -438,4 +441,4 @@ exports["default"] = _default;
/***/ })
-},[["V8Sf",0,1,2]]]);
\ No newline at end of file
+},[["0Mts",0,1,2]]]);
\ No newline at end of fileDiff for link.module.js
@@ -1,5 +1,21 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+/***/ "0Mts":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/link",
+ function () {
+ var mod = __webpack_require__("ObF3");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
+/***/ }),
+
/***/ "ObF3":
/***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -23,19 +39,6 @@ aLink.getInitialProps = () => ({});
/* harmony default export */ __webpack_exports__["default"] = (aLink);
-/***/ }),
-
-/***/ "V8Sf":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/link", function() {
- var mod = __webpack_require__("ObF3")
- if(false) {}
- return mod
- }]);
-
-
/***/ }),
/***/ "YFqc":
@@ -337,4 +340,4 @@ exports.default = _default;
/***/ })
-},[["V8Sf",0,1,2]]]);
\ No newline at end of file
+},[["0Mts",0,1,2]]]);
\ No newline at end of fileDiff for routerDirect.js
@@ -1,14 +1,17 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
-/***/ "LtRI":
+/***/ "ezis":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/routerDirect", function() {
- var mod = __webpack_require__("jSAA")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/routerDirect",
+ function () {
+ var mod = __webpack_require__("jSAA");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ }),
@@ -40,4 +43,4 @@ routerDirect.getInitialProps = function () {
/***/ })
-},[["LtRI",0,1,2]]]);
\ No newline at end of file
+},[["ezis",0,1,2]]]);
\ No newline at end of fileDiff for routerDirect.module.js
@@ -1,14 +1,17 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
-/***/ "LtRI":
+/***/ "ezis":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/routerDirect", function() {
- var mod = __webpack_require__("jSAA")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/routerDirect",
+ function () {
+ var mod = __webpack_require__("jSAA");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ }),
@@ -38,4 +41,4 @@ routerDirect.getInitialProps = () => ({});
/***/ })
-},[["LtRI",0,1,2]]]);
\ No newline at end of file
+},[["ezis",0,1,2]]]);
\ No newline at end of fileDiff for withRouter.js
@@ -25,17 +25,20 @@ useWithRouter.getInitialProps = function () {
/***/ }),
-/***/ "eThv":
+/***/ "Cyhe":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/withRouter", function() {
- var mod = __webpack_require__("0Hlz")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/withRouter",
+ function () {
+ var mod = __webpack_require__("0Hlz");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["eThv",0,1,2]]]);
\ No newline at end of file
+},[["Cyhe",0,1,2]]]);
\ No newline at end of fileDiff for withRouter.module.js
@@ -23,17 +23,20 @@ useWithRouter.getInitialProps = () => ({});
/***/ }),
-/***/ "eThv":
+/***/ "Cyhe":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/withRouter", function() {
- var mod = __webpack_require__("0Hlz")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/withRouter",
+ function () {
+ var mod = __webpack_require__("0Hlz");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["eThv",0,1,2]]]);
\ No newline at end of file
+},[["Cyhe",0,1,2]]]);
\ No newline at end of fileServerless Mode
General Overall increase ⚠️
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| buildDuration | 13.1s | 12.9s | -273ms |
| nodeModulesSize | 55.5 MB | 55.5 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.25 kB | 6.25 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..5e5e.js gzip | 10.3 kB | 10.3 kB | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| Overall change | 56.7 kB | 56.7 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.79 kB | 4.79 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.85 kB | 6.85 kB | ✓ |
| framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
| Overall change | 51.4 kB | 51.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.2 kB | 26.2 kB | ✓ |
| Overall change | 26.2 kB | 26.2 kB | ✓ |
Client Pages
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.24 kB | |
| _error.js gzip | 3.12 kB | 3.12 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.06 kB | 2.06 kB | -3 B |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 279 B | |
| Overall change | 7.86 kB | 7.86 kB | ✓ |
Client Pages Modern Overall increase ⚠️
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _app.module.js gzip | 602 B | 603 B | |
| _error.module.js gzip | 2.09 kB | 2.09 kB | |
| hooks.module.js gzip | 383 B | 383 B | ✓ |
| index.module.js gzip | 223 B | 222 B | -1 B |
| link.module.js gzip | 1.52 kB | 1.52 kB | -1 B |
| routerDirect..dule.js gzip | 281 B | 280 B | -1 B |
| withRouter.m..dule.js gzip | 278 B | 279 B | |
| Overall change | 5.38 kB | 5.38 kB |
Client Build Manifests
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _error.js | 558 kB | 558 kB | ✓ |
| 404.html | 4.18 kB | 4.18 kB | ✓ |
| hooks.html | 3.81 kB | 3.81 kB | ✓ |
| index.js | 558 kB | 558 kB | ✓ |
| link.js | 594 kB | 594 kB | ✓ |
| routerDirect.js | 587 kB | 587 kB | ✓ |
| withRouter.js | 587 kB | 587 kB | ✓ |
| Overall change | 2.89 MB | 2.89 MB | ✓ |
Failing test suitestest/integration/production-config/test/index.test.js
Expand output● Production Config Usage › with generateBuildId › should add the custom buildid |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| buildDuration | 12s | 12.2s | |
| nodeModulesSize | 55.5 MB | 55.5 MB |
Page Load Tests Overall decrease ⚠️
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.056 | 2.102 | |
| / avg req/sec | 1216.2 | 1189.19 | -27.01 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.235 | 1.228 | -0.01 |
| /error-in-render avg req/sec | 2024.71 | 2036.28 |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.25 kB | 6.25 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..5e5e.js gzip | 10.3 kB | 10.3 kB | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| Overall change | 56.7 kB | 56.7 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.79 kB | 4.79 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.85 kB | 6.85 kB | ✓ |
| framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
| Overall change | 51.4 kB | 51.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.2 kB | 26.2 kB | ✓ |
| Overall change | 26.2 kB | 26.2 kB | ✓ |
Client Pages Overall decrease ✓
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.23 kB | -4 B |
| _error.js gzip | 3.12 kB | 3.12 kB | |
| hooks.js gzip | 664 B | 663 B | -1 B |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.06 kB | 2.06 kB | ✓ |
| routerDirect.js gzip | 279 B | 280 B | |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.85 kB | -2 B |
Client Pages Modern Overall decrease ✓
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _app.module.js gzip | 602 B | 598 B | -4 B |
| _error.module.js gzip | 2.09 kB | 2.09 kB | |
| hooks.module.js gzip | 383 B | 383 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js gzip | 1.52 kB | 1.52 kB | -1 B |
| routerDirect..dule.js gzip | 281 B | 279 B | -2 B |
| withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
| Overall change | 5.38 kB | 5.37 kB | -2 B |
Client Build Manifests
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| index.html gzip | 927 B | 927 B | ✓ |
| link.html gzip | 937 B | 937 B | ✓ |
| withRouter.html gzip | 924 B | 924 B | ✓ |
| Overall change | 2.79 kB | 2.79 kB | ✓ |
Diffs
Diff for _app.js
@@ -1,9 +1,25 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+/***/ "++dY":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/_app",
+ function () {
+ var mod = __webpack_require__("B5Ud");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
+/***/ }),
+
/***/ 0:
/***/ (function(module, exports, __webpack_require__) {
-__webpack_require__("e9+W");
+__webpack_require__("++dY");
module.exports = __webpack_require__("nOHt");
@@ -245,19 +261,6 @@ function _possibleConstructorReturn(self, call) {
module.exports = _possibleConstructorReturn;
-/***/ }),
-
-/***/ "e9+W":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/_app", function() {
- var mod = __webpack_require__("B5Ud")
- if(false) {}
- return mod
- }]);
-
-
/***/ })
},[[0,0,1,2]]]);
\ No newline at end of fileDiff for _app.module.js
@@ -1,9 +1,25 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+/***/ "++dY":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/_app",
+ function () {
+ var mod = __webpack_require__("B5Ud");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
+/***/ }),
+
/***/ 0:
/***/ (function(module, exports, __webpack_require__) {
-__webpack_require__("e9+W");
+__webpack_require__("++dY");
module.exports = __webpack_require__("nOHt");
@@ -132,19 +148,6 @@ function createUrl(router) {
};
}
-/***/ }),
-
-/***/ "e9+W":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/_app", function() {
- var mod = __webpack_require__("B5Ud")
- if(false) {}
- return mod
- }]);
-
-
/***/ })
},[[0,0,1,2]]]);
\ No newline at end of fileDiff for _error.js
@@ -169,19 +169,6 @@ var styles = {
}
};
-/***/ }),
-
-/***/ "04ac":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/_error", function() {
- var mod = __webpack_require__("/a9y")
- if(false) {}
- return mod
- }]);
-
-
/***/ }),
/***/ "7W2i":
@@ -740,6 +727,22 @@ function _classCallCheck(instance, Constructor) {
module.exports = _classCallCheck;
+/***/ }),
+
+/***/ "nHv3":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/_error",
+ function () {
+ var mod = __webpack_require__("/a9y");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ })
-},[["04ac",0,1]]]);
\ No newline at end of file
+},[["nHv3",0,1]]]);
\ No newline at end of fileDiff for _error.module.js
@@ -142,19 +142,6 @@ var styles = {
}
};
-/***/ }),
-
-/***/ "04ac":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/_error", function() {
- var mod = __webpack_require__("/a9y")
- if(false) {}
- return mod
- }]);
-
-
/***/ }),
/***/ "8Kt/":
@@ -470,6 +457,22 @@ exports.AmpStateContext = React.createContext({});
if (false) {}
+/***/ }),
+
+/***/ "nHv3":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/_error",
+ function () {
+ var mod = __webpack_require__("/a9y");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ })
-},[["04ac",0,1]]]);
\ No newline at end of file
+},[["nHv3",0,1]]]);
\ No newline at end of fileDiff for hooks.js
@@ -93,17 +93,20 @@ var assign=Object.assign.bind(Object);module.exports=assign;module.exports.defau
/***/ }),
-/***/ "g1vQ":
+/***/ "plgv":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/hooks", function() {
- var mod = __webpack_require__("+MDD")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/hooks",
+ function () {
+ var mod = __webpack_require__("+MDD");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["g1vQ",0,1]]]);
\ No newline at end of file
+},[["plgv",0,1]]]);
\ No newline at end of fileDiff for hooks.module.js
@@ -38,17 +38,20 @@ var assign=Object.assign.bind(Object);module.exports=assign;module.exports.defau
/***/ }),
-/***/ "g1vQ":
+/***/ "plgv":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/hooks", function() {
- var mod = __webpack_require__("+MDD")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/hooks",
+ function () {
+ var mod = __webpack_require__("+MDD");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["g1vQ",0,1]]]);
\ No newline at end of file
+},[["plgv",0,1]]]);
\ No newline at end of fileDiff for index.js
@@ -17,17 +17,20 @@ Page.getInitialProps = function () {
/***/ }),
-/***/ "vlRD":
+/***/ "m0L+":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/", function() {
- var mod = __webpack_require__("RNiq")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/",
+ function () {
+ var mod = __webpack_require__("RNiq");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["vlRD",0]]]);
\ No newline at end of file
+},[["m0L+",0]]]);
\ No newline at end of fileDiff for index.module.js
@@ -13,17 +13,20 @@ Page.getInitialProps = () => ({});
/***/ }),
-/***/ "vlRD":
+/***/ "m0L+":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/", function() {
- var mod = __webpack_require__("RNiq")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/",
+ function () {
+ var mod = __webpack_require__("RNiq");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["vlRD",0]]]);
\ No newline at end of file
+},[["m0L+",0]]]);
\ No newline at end of fileDiff for link.js
@@ -22,6 +22,22 @@ function _inherits(subClass, superClass) {
module.exports = _inherits;
+/***/ }),
+
+/***/ "GwDo":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/link",
+ function () {
+ var mod = __webpack_require__("ObF3");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ }),
/***/ "Nsbk":
@@ -78,19 +94,6 @@ function _assertThisInitialized(self) {
module.exports = _assertThisInitialized;
-/***/ }),
-
-/***/ "V8Sf":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/link", function() {
- var mod = __webpack_require__("ObF3")
- if(false) {}
- return mod
- }]);
-
-
/***/ }),
/***/ "YFqc":
@@ -438,4 +441,4 @@ exports["default"] = _default;
/***/ })
-},[["V8Sf",0,1,2]]]);
\ No newline at end of file
+},[["GwDo",0,1,2]]]);
\ No newline at end of fileDiff for link.module.js
@@ -1,5 +1,21 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+/***/ "GwDo":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/link",
+ function () {
+ var mod = __webpack_require__("ObF3");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
+/***/ }),
+
/***/ "ObF3":
/***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -23,19 +39,6 @@ aLink.getInitialProps = () => ({});
/* harmony default export */ __webpack_exports__["default"] = (aLink);
-/***/ }),
-
-/***/ "V8Sf":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/link", function() {
- var mod = __webpack_require__("ObF3")
- if(false) {}
- return mod
- }]);
-
-
/***/ }),
/***/ "YFqc":
@@ -337,4 +340,4 @@ exports.default = _default;
/***/ })
-},[["V8Sf",0,1,2]]]);
\ No newline at end of file
+},[["GwDo",0,1,2]]]);
\ No newline at end of fileDiff for routerDirect.js
@@ -1,18 +1,5 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
-/***/ "LtRI":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/routerDirect", function() {
- var mod = __webpack_require__("jSAA")
- if(false) {}
- return mod
- }]);
-
-
-/***/ }),
-
/***/ "jSAA":
/***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -38,6 +25,22 @@ routerDirect.getInitialProps = function () {
/* harmony default export */ __webpack_exports__["default"] = (routerDirect);
+/***/ }),
+
+/***/ "ksEn":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/routerDirect",
+ function () {
+ var mod = __webpack_require__("jSAA");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ })
-},[["LtRI",0,1,2]]]);
\ No newline at end of file
+},[["ksEn",0,1,2]]]);
\ No newline at end of fileDiff for routerDirect.module.js
@@ -1,18 +1,5 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
-/***/ "LtRI":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/routerDirect", function() {
- var mod = __webpack_require__("jSAA")
- if(false) {}
- return mod
- }]);
-
-
-/***/ }),
-
/***/ "jSAA":
/***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -36,6 +23,22 @@ routerDirect.getInitialProps = () => ({});
/* harmony default export */ __webpack_exports__["default"] = (routerDirect);
+/***/ }),
+
+/***/ "ksEn":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/routerDirect",
+ function () {
+ var mod = __webpack_require__("jSAA");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ })
-},[["LtRI",0,1,2]]]);
\ No newline at end of file
+},[["ksEn",0,1,2]]]);
\ No newline at end of fileDiff for withRouter.js
@@ -25,17 +25,20 @@ useWithRouter.getInitialProps = function () {
/***/ }),
-/***/ "eThv":
+/***/ "eqah":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/withRouter", function() {
- var mod = __webpack_require__("0Hlz")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/withRouter",
+ function () {
+ var mod = __webpack_require__("0Hlz");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["eThv",0,1,2]]]);
\ No newline at end of file
+},[["eqah",0,1,2]]]);
\ No newline at end of fileDiff for withRouter.module.js
@@ -23,17 +23,20 @@ useWithRouter.getInitialProps = () => ({});
/***/ }),
-/***/ "eThv":
+/***/ "eqah":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/withRouter", function() {
- var mod = __webpack_require__("0Hlz")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/withRouter",
+ function () {
+ var mod = __webpack_require__("0Hlz");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["eThv",0,1,2]]]);
\ No newline at end of file
+},[["eqah",0,1,2]]]);
\ No newline at end of fileServerless Mode (Decrease detected ✓)
General Overall increase ⚠️
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| buildDuration | 12.8s | 12.7s | -160ms |
| nodeModulesSize | 55.5 MB | 55.5 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.25 kB | 6.25 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..5e5e.js gzip | 10.3 kB | 10.3 kB | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| Overall change | 56.7 kB | 56.7 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.79 kB | 4.79 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.85 kB | 6.85 kB | ✓ |
| framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
| Overall change | 51.4 kB | 51.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.2 kB | 26.2 kB | ✓ |
| Overall change | 26.2 kB | 26.2 kB | ✓ |
Client Pages Overall decrease ✓
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.23 kB | -4 B |
| _error.js gzip | 3.12 kB | 3.12 kB | |
| hooks.js gzip | 664 B | 663 B | -1 B |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.06 kB | 2.06 kB | ✓ |
| routerDirect.js gzip | 279 B | 280 B | |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.85 kB | -2 B |
Client Pages Modern Overall decrease ✓
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _app.module.js gzip | 602 B | 598 B | -4 B |
| _error.module.js gzip | 2.09 kB | 2.09 kB | |
| hooks.module.js gzip | 383 B | 383 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js gzip | 1.52 kB | 1.52 kB | -1 B |
| routerDirect..dule.js gzip | 281 B | 279 B | -2 B |
| withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
| Overall change | 5.38 kB | 5.37 kB | -2 B |
Client Build Manifests
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _error.js | 558 kB | 558 kB | ✓ |
| 404.html | 4.18 kB | 4.18 kB | ✓ |
| hooks.html | 3.81 kB | 3.81 kB | ✓ |
| index.js | 558 kB | 558 kB | ✓ |
| link.js | 594 kB | 594 kB | ✓ |
| routerDirect.js | 587 kB | 587 kB | ✓ |
| withRouter.js | 587 kB | 587 kB | ✓ |
| Overall change | 2.89 MB | 2.89 MB | ✓ |
Failing test suitestest/integration/production-config/test/index.test.js
Expand output● Production Config Usage › with generateBuildId › should add the custom buildid |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| buildDuration | 10.7s | 10.8s | |
| nodeModulesSize | 55.5 MB | 55.5 MB |
Page Load Tests Overall decrease ⚠️
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 1.835 | 1.766 | -0.07 |
| / avg req/sec | 1362.41 | 1415.47 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 0.905 | 0.931 | |
| /error-in-render avg req/sec | 2762.34 | 2684.26 | -78.08 |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.25 kB | 6.25 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..5e5e.js gzip | 10.3 kB | 10.3 kB | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| Overall change | 56.7 kB | 56.7 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.79 kB | 4.79 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.85 kB | 6.85 kB | ✓ |
| framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
| Overall change | 51.4 kB | 51.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.2 kB | 26.2 kB | ✓ |
| Overall change | 26.2 kB | 26.2 kB | ✓ |
Client Pages Overall decrease ✓
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.23 kB | -4 B |
| _error.js gzip | 3.12 kB | 3.12 kB | |
| hooks.js gzip | 664 B | 663 B | -1 B |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.06 kB | 2.06 kB | ✓ |
| routerDirect.js gzip | 279 B | 280 B | |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.85 kB | -2 B |
Client Pages Modern Overall decrease ✓
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _app.module.js gzip | 602 B | 598 B | -4 B |
| _error.module.js gzip | 2.09 kB | 2.09 kB | |
| hooks.module.js gzip | 383 B | 383 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js gzip | 1.52 kB | 1.52 kB | -1 B |
| routerDirect..dule.js gzip | 281 B | 279 B | -2 B |
| withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
| Overall change | 5.38 kB | 5.37 kB | -2 B |
Client Build Manifests
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| index.html gzip | 927 B | 927 B | ✓ |
| link.html gzip | 937 B | 937 B | ✓ |
| withRouter.html gzip | 924 B | 924 B | ✓ |
| Overall change | 2.79 kB | 2.79 kB | ✓ |
Diffs
Diff for _app.js
@@ -1,9 +1,25 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+/***/ "++dY":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/_app",
+ function () {
+ var mod = __webpack_require__("B5Ud");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
+/***/ }),
+
/***/ 0:
/***/ (function(module, exports, __webpack_require__) {
-__webpack_require__("e9+W");
+__webpack_require__("++dY");
module.exports = __webpack_require__("nOHt");
@@ -245,19 +261,6 @@ function _possibleConstructorReturn(self, call) {
module.exports = _possibleConstructorReturn;
-/***/ }),
-
-/***/ "e9+W":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/_app", function() {
- var mod = __webpack_require__("B5Ud")
- if(false) {}
- return mod
- }]);
-
-
/***/ })
},[[0,0,1,2]]]);
\ No newline at end of fileDiff for _app.module.js
@@ -1,9 +1,25 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+/***/ "++dY":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/_app",
+ function () {
+ var mod = __webpack_require__("B5Ud");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
+/***/ }),
+
/***/ 0:
/***/ (function(module, exports, __webpack_require__) {
-__webpack_require__("e9+W");
+__webpack_require__("++dY");
module.exports = __webpack_require__("nOHt");
@@ -132,19 +148,6 @@ function createUrl(router) {
};
}
-/***/ }),
-
-/***/ "e9+W":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/_app", function() {
- var mod = __webpack_require__("B5Ud")
- if(false) {}
- return mod
- }]);
-
-
/***/ })
},[[0,0,1,2]]]);
\ No newline at end of fileDiff for _error.js
@@ -169,19 +169,6 @@ var styles = {
}
};
-/***/ }),
-
-/***/ "04ac":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/_error", function() {
- var mod = __webpack_require__("/a9y")
- if(false) {}
- return mod
- }]);
-
-
/***/ }),
/***/ "7W2i":
@@ -740,6 +727,22 @@ function _classCallCheck(instance, Constructor) {
module.exports = _classCallCheck;
+/***/ }),
+
+/***/ "nHv3":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/_error",
+ function () {
+ var mod = __webpack_require__("/a9y");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ })
-},[["04ac",0,1]]]);
\ No newline at end of file
+},[["nHv3",0,1]]]);
\ No newline at end of fileDiff for _error.module.js
@@ -142,19 +142,6 @@ var styles = {
}
};
-/***/ }),
-
-/***/ "04ac":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/_error", function() {
- var mod = __webpack_require__("/a9y")
- if(false) {}
- return mod
- }]);
-
-
/***/ }),
/***/ "8Kt/":
@@ -470,6 +457,22 @@ exports.AmpStateContext = React.createContext({});
if (false) {}
+/***/ }),
+
+/***/ "nHv3":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/_error",
+ function () {
+ var mod = __webpack_require__("/a9y");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ })
-},[["04ac",0,1]]]);
\ No newline at end of file
+},[["nHv3",0,1]]]);
\ No newline at end of fileDiff for hooks.js
@@ -93,17 +93,20 @@ var assign=Object.assign.bind(Object);module.exports=assign;module.exports.defau
/***/ }),
-/***/ "g1vQ":
+/***/ "plgv":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/hooks", function() {
- var mod = __webpack_require__("+MDD")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/hooks",
+ function () {
+ var mod = __webpack_require__("+MDD");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["g1vQ",0,1]]]);
\ No newline at end of file
+},[["plgv",0,1]]]);
\ No newline at end of fileDiff for hooks.module.js
@@ -38,17 +38,20 @@ var assign=Object.assign.bind(Object);module.exports=assign;module.exports.defau
/***/ }),
-/***/ "g1vQ":
+/***/ "plgv":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/hooks", function() {
- var mod = __webpack_require__("+MDD")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/hooks",
+ function () {
+ var mod = __webpack_require__("+MDD");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["g1vQ",0,1]]]);
\ No newline at end of file
+},[["plgv",0,1]]]);
\ No newline at end of fileDiff for index.js
@@ -17,17 +17,20 @@ Page.getInitialProps = function () {
/***/ }),
-/***/ "vlRD":
+/***/ "m0L+":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/", function() {
- var mod = __webpack_require__("RNiq")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/",
+ function () {
+ var mod = __webpack_require__("RNiq");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["vlRD",0]]]);
\ No newline at end of file
+},[["m0L+",0]]]);
\ No newline at end of fileDiff for index.module.js
@@ -13,17 +13,20 @@ Page.getInitialProps = () => ({});
/***/ }),
-/***/ "vlRD":
+/***/ "m0L+":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/", function() {
- var mod = __webpack_require__("RNiq")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/",
+ function () {
+ var mod = __webpack_require__("RNiq");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["vlRD",0]]]);
\ No newline at end of file
+},[["m0L+",0]]]);
\ No newline at end of fileDiff for link.js
@@ -22,6 +22,22 @@ function _inherits(subClass, superClass) {
module.exports = _inherits;
+/***/ }),
+
+/***/ "GwDo":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/link",
+ function () {
+ var mod = __webpack_require__("ObF3");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ }),
/***/ "Nsbk":
@@ -78,19 +94,6 @@ function _assertThisInitialized(self) {
module.exports = _assertThisInitialized;
-/***/ }),
-
-/***/ "V8Sf":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/link", function() {
- var mod = __webpack_require__("ObF3")
- if(false) {}
- return mod
- }]);
-
-
/***/ }),
/***/ "YFqc":
@@ -438,4 +441,4 @@ exports["default"] = _default;
/***/ })
-},[["V8Sf",0,1,2]]]);
\ No newline at end of file
+},[["GwDo",0,1,2]]]);
\ No newline at end of fileDiff for link.module.js
@@ -1,5 +1,21 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+/***/ "GwDo":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/link",
+ function () {
+ var mod = __webpack_require__("ObF3");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
+/***/ }),
+
/***/ "ObF3":
/***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -23,19 +39,6 @@ aLink.getInitialProps = () => ({});
/* harmony default export */ __webpack_exports__["default"] = (aLink);
-/***/ }),
-
-/***/ "V8Sf":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/link", function() {
- var mod = __webpack_require__("ObF3")
- if(false) {}
- return mod
- }]);
-
-
/***/ }),
/***/ "YFqc":
@@ -337,4 +340,4 @@ exports.default = _default;
/***/ })
-},[["V8Sf",0,1,2]]]);
\ No newline at end of file
+},[["GwDo",0,1,2]]]);
\ No newline at end of fileDiff for routerDirect.js
@@ -1,18 +1,5 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
-/***/ "LtRI":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/routerDirect", function() {
- var mod = __webpack_require__("jSAA")
- if(false) {}
- return mod
- }]);
-
-
-/***/ }),
-
/***/ "jSAA":
/***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -38,6 +25,22 @@ routerDirect.getInitialProps = function () {
/* harmony default export */ __webpack_exports__["default"] = (routerDirect);
+/***/ }),
+
+/***/ "ksEn":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/routerDirect",
+ function () {
+ var mod = __webpack_require__("jSAA");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ })
-},[["LtRI",0,1,2]]]);
\ No newline at end of file
+},[["ksEn",0,1,2]]]);
\ No newline at end of fileDiff for routerDirect.module.js
@@ -1,18 +1,5 @@
(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
-/***/ "LtRI":
-/***/ (function(module, exports, __webpack_require__) {
-
-
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/routerDirect", function() {
- var mod = __webpack_require__("jSAA")
- if(false) {}
- return mod
- }]);
-
-
-/***/ }),
-
/***/ "jSAA":
/***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -36,6 +23,22 @@ routerDirect.getInitialProps = () => ({});
/* harmony default export */ __webpack_exports__["default"] = (routerDirect);
+/***/ }),
+
+/***/ "ksEn":
+/***/ (function(module, exports, __webpack_require__) {
+
+
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/routerDirect",
+ function () {
+ var mod = __webpack_require__("jSAA");
+ if (false) {}
+ return mod;
+ }
+ ]);
+
+
/***/ })
-},[["LtRI",0,1,2]]]);
\ No newline at end of file
+},[["ksEn",0,1,2]]]);
\ No newline at end of fileDiff for withRouter.js
@@ -25,17 +25,20 @@ useWithRouter.getInitialProps = function () {
/***/ }),
-/***/ "eThv":
+/***/ "eqah":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/withRouter", function() {
- var mod = __webpack_require__("0Hlz")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/withRouter",
+ function () {
+ var mod = __webpack_require__("0Hlz");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["eThv",0,1,2]]]);
\ No newline at end of file
+},[["eqah",0,1,2]]]);
\ No newline at end of fileDiff for withRouter.module.js
@@ -23,17 +23,20 @@ useWithRouter.getInitialProps = () => ({});
/***/ }),
-/***/ "eThv":
+/***/ "eqah":
/***/ (function(module, exports, __webpack_require__) {
- (window.__NEXT_P=window.__NEXT_P||[]).push(["/withRouter", function() {
- var mod = __webpack_require__("0Hlz")
- if(false) {}
- return mod
- }]);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/withRouter",
+ function () {
+ var mod = __webpack_require__("0Hlz");
+ if (false) {}
+ return mod;
+ }
+ ]);
/***/ })
-},[["eThv",0,1,2]]]);
\ No newline at end of file
+},[["eqah",0,1,2]]]);
\ No newline at end of fileServerless Mode (Decrease detected ✓)
General Overall increase ⚠️
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| buildDuration | 11.8s | 11.8s | |
| nodeModulesSize | 55.5 MB | 55.5 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.25 kB | 6.25 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..5e5e.js gzip | 10.3 kB | 10.3 kB | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.a1..NSE.txt gzip | 220 B | 220 B | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| Overall change | 56.7 kB | 56.7 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.79 kB | 4.79 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.85 kB | 6.85 kB | ✓ |
| framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
| Overall change | 51.4 kB | 51.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.2 kB | 26.2 kB | ✓ |
| Overall change | 26.2 kB | 26.2 kB | ✓ |
Client Pages Overall decrease ✓
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.23 kB | -4 B |
| _error.js gzip | 3.12 kB | 3.12 kB | |
| hooks.js gzip | 664 B | 663 B | -1 B |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.06 kB | 2.06 kB | ✓ |
| routerDirect.js gzip | 279 B | 280 B | |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.85 kB | -2 B |
Client Pages Modern Overall decrease ✓
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _app.module.js gzip | 602 B | 598 B | -4 B |
| _error.module.js gzip | 2.09 kB | 2.09 kB | |
| hooks.module.js gzip | 383 B | 383 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js gzip | 1.52 kB | 1.52 kB | -1 B |
| routerDirect..dule.js gzip | 281 B | 279 B | -2 B |
| withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
| Overall change | 5.38 kB | 5.37 kB | -2 B |
Client Build Manifests
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles
| zeit/next.js canary | Timer/next.js refactor/add-toggle-hmr | Change | |
|---|---|---|---|
| _error.js | 558 kB | 558 kB | ✓ |
| 404.html | 4.18 kB | 4.18 kB | ✓ |
| hooks.html | 3.81 kB | 3.81 kB | ✓ |
| index.js | 558 kB | 558 kB | ✓ |
| link.js | 594 kB | 594 kB | ✓ |
| routerDirect.js | 587 kB | 587 kB | ✓ |
| withRouter.js | 587 kB | 587 kB | ✓ |
| Overall change | 2.89 MB | 2.89 MB | ✓ |
ijjk
approved these changes
Apr 18, 2020
This was referenced May 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new property,
hotRouterUpdates, which gives finer-grain control over whether or not themodule.hotAPI is used in Next.js' router.This feature will be used to turn off this legacy-mode when Fast Refresh is the new default (or opted-in to).