Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] Update mobx examples to not use SSR #11576

Merged
merged 6 commits into from
Apr 7, 2020

Conversation

lfades
Copy link
Member

@lfades lfades commented Apr 1, 2020

Updated 4 examples, including 2 of Mobx to not use SSR anymore.

Also tried updating another 2 Mobx related examples (with-mobx-state-tree) but after removing SSR from those they basically looked the same as the other examples, and didn't work as expected 🤔

@lfades lfades requested a review from Timer as a code owner April 1, 2020 23:41
@ijjk
Copy link
Member

ijjk commented Apr 1, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary lfades/next.js examples/mobx-no-ssr Change
buildDuration 9.8s 9.8s ⚠️ +9ms
nodeModulesSize 47.7 MB 47.7 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary lfades/next.js examples/mobx-no-ssr Change
main-HASH.js gzip 6.24 kB 6.24 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.2 kB 56.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lfades/next.js examples/mobx-no-ssr Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary lfades/next.js examples/mobx-no-ssr Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary lfades/next.js examples/mobx-no-ssr Change
_app.js gzip 1.24 kB 1.24 kB
_error.js gzip 3.15 kB 3.15 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 2.03 kB 2.03 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary lfades/next.js examples/mobx-no-ssr Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary lfades/next.js examples/mobx-no-ssr Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary lfades/next.js examples/mobx-no-ssr Change
index.html gzip 918 B 918 B
link.html gzip 926 B 926 B
withRouter.html gzip 916 B 916 B
Overall change 2.76 kB 2.76 kB

Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary lfades/next.js examples/mobx-no-ssr Change
buildDuration 10.5s 10.4s -66ms
nodeModulesSize 47.7 MB 47.7 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary lfades/next.js examples/mobx-no-ssr Change
main-HASH.js gzip 6.24 kB 6.24 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.2 kB 56.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lfades/next.js examples/mobx-no-ssr Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary lfades/next.js examples/mobx-no-ssr Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary lfades/next.js examples/mobx-no-ssr Change
_app.js gzip 1.24 kB 1.24 kB
_error.js gzip 3.15 kB 3.15 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 2.03 kB 2.03 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary lfades/next.js examples/mobx-no-ssr Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary lfades/next.js examples/mobx-no-ssr Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall decrease ✓
zeit/next.js canary lfades/next.js examples/mobx-no-ssr Change
_error.js gzip 232 kB 232 kB -317 B
404.html gzip 1.32 kB 1.32 kB
hooks.html gzip 959 B 959 B
index.js gzip 232 kB 233 kB ⚠️ +157 B
link.js gzip 243 kB 243 kB ⚠️ +23 B
routerDirect.js gzip 241 kB 241 kB ⚠️ +60 B
withRouter.js gzip 240 kB 240 kB ⚠️ +43 B
Overall change 1.19 MB 1.19 MB -34 B

@bausk
Copy link

bausk commented Apr 3, 2020

I've been using this PR to base my implementation off of and I just wanted to do a sanity check, is the reason to remove SSR from these examples to make them more atomic, or because SSR has any incompatibilities with using MobX in Nextjs? Thanks

@timneutkens timneutkens added the examples Issue was opened via the examples template. label Apr 6, 2020
@Timer Timer added this to the 9.3.5 milestone Apr 7, 2020
@Timer Timer merged commit 1239d5a into vercel:canary Apr 7, 2020
@lfades
Copy link
Member Author

lfades commented Apr 7, 2020

@bausk To make them statically optimizable, usually you won't need the store in the server, so there's no need to turn the entire app into slower serverless functions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants