Pre-ncc compiled packages to prevent re-nccing unnecessarily #11569

ijjk · 2020-04-01T21:19:23Z

This attempts to speed up local development and pre-publish build times by pre-nccing and committing the compiled packages to our repo since they should only change when we update/add new packages to be ncc'd and don't need to be re-ncc'd every time we are building next locally for development or every time before publish

Before this optimization
Dev build startup: 23 - 25 seconds
Prod build: 52 - 55 seconds

After this optimization
Dev build startup: 5 - 7 seconds
Prod build: 35 - 37 seconds

Before

After

ijjk · 2020-04-01T21:26:01Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
buildDuration	11.2s	11s	-243ms
nodeModulesSize	47.7 MB	52.4 MB	⚠️ +4.71 MB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
index.html gzip	918 B	918 B	✓
link.html gzip	926 B	926 B	✓
withRouter.html gzip	916 B	916 B	✓
Overall change	2.76 kB	2.76 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
buildDuration	11.8s	11.8s	⚠️ +42ms
nodeModulesSize	47.7 MB	52.4 MB	⚠️ +4.71 MB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
_error.js gzip	232 kB	233 kB	⚠️ +115 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	959 B	959 B	✓
index.js gzip	232 kB	232 kB	-93 B
link.js gzip	243 kB	242 kB	-295 B
routerDirect.js gzip	241 kB	240 kB	-160 B
withRouter.js gzip	241 kB	241 kB	-69 B
Overall change	1.19 MB	1.19 MB	-502 B

Timer

Can we add a new GH action step (similar to lint step) that runs ncc and verifies the versions we have checked in are up to date (basically that git tree is clean after a build)?

ijjk · 2020-04-06T17:01:39Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
buildDuration	10.9s	11s	⚠️ +93ms
nodeModulesSize	47.7 MB	52.4 MB	⚠️ +4.71 MB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..e3d8.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.3 kB	56.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.78 kB	6.78 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.5 kB	51.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
index.html gzip	918 B	918 B	✓
link.html gzip	927 B	927 B	✓
withRouter.html gzip	914 B	914 B	✓
Overall change	2.76 kB	2.76 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
buildDuration	11.5s	11.5s	-18ms
nodeModulesSize	47.7 MB	52.4 MB	⚠️ +4.71 MB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..e3d8.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.3 kB	56.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.78 kB	6.78 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.5 kB	51.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	ijjk/next.js add/pre-nccing	Change
_error.js gzip	233 kB	233 kB	⚠️ +297 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	957 B	957 B	✓
index.js gzip	233 kB	233 kB	-451 B
link.js gzip	243 kB	243 kB	-221 B
routerDirect.js gzip	241 kB	241 kB	⚠️ +44 B
withRouter.js gzip	241 kB	241 kB	⚠️ +263 B
Overall change	1.19 MB	1.19 MB	-68 B

ijjk · 2020-04-06T17:04:15Z

Added a check to our actions workflow to make sure the tree is clean after re-running the pre-compile task

ijjk added 2 commits April 1, 2020 15:58

Pre-ncc compiled packages to prevent re-nccing unnecessarily

f33ae1e

Add compiled files

04dba90

ijjk requested a review from Timer April 1, 2020 21:19

ijjk marked this pull request as ready for review April 2, 2020 16:16

ijjk requested review from lfades and timneutkens as code owners April 2, 2020 16:16

timneutkens added the type: next label Apr 6, 2020

Timer requested changes Apr 6, 2020

View reviewed changes

ijjk added 3 commits April 6, 2020 10:28

Merge remote-tracking branch 'upstream/canary' into add/pre-nccing

8e9ad8a

Re-run pre-ncc step

a38415d

Add check to workflow to ensure pre-compiled doesnt need updating

7a62f66

This comment has been minimized.

Sign in to view

Update check-pre-compiled script

1a07de2

This comment has been minimized.

Sign in to view

ijjk added 3 commits April 6, 2020 11:13

Add handling for lower case license while nccing

7be5b21

Merge remote-tracking branch 'upstream/canary' into add/pre-nccing

88b7b34

bump

b64ed20

This comment has been minimized.

Sign in to view

Merge branch 'canary' into add/pre-nccing

ef1db87

ijjk requested a review from Timer April 6, 2020 17:03

Timer added this to the 9.3.5 milestone Apr 7, 2020

Merge branch 'canary' into add/pre-nccing

6f120d8

Timer approved these changes Apr 7, 2020

View reviewed changes

Timer merged commit 84b89c8 into vercel:canary Apr 7, 2020

Timer deleted the add/pre-nccing branch April 7, 2020 13:42

This was referenced Apr 17, 2020

[Snyk] Upgrade next from 9.3.4 to 9.3.5 anephenix/ui#4

Merged

[Snyk] Upgrade next from 9.3.4 to 9.3.5 yowainwright/Advanced-React#61

Merged

snyk-bot mentioned this pull request Apr 20, 2020

[Snyk] Upgrade next from 9.3.2 to 9.3.5 tuan231195/sportywide-news#3

Closed

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pre-ncc compiled packages to prevent re-nccing unnecessarily #11569

Pre-ncc compiled packages to prevent re-nccing unnecessarily #11569

ijjk commented Apr 1, 2020

ijjk commented Apr 1, 2020

Timer left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Apr 6, 2020

ijjk commented Apr 6, 2020

Pre-ncc compiled packages to prevent re-nccing unnecessarily #11569

Pre-ncc compiled packages to prevent re-nccing unnecessarily #11569

Conversation

ijjk commented Apr 1, 2020

ijjk commented Apr 1, 2020

Stats from current PR

Timer left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Apr 6, 2020

Stats from current PR

ijjk commented Apr 6, 2020