Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not cache 404 responses (ssr-caching) #10596

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Do not cache 404 responses (ssr-caching) #10596

merged 1 commit into from
Feb 19, 2020

Conversation

fabianishere
Copy link
Contributor

Following the discussion in #10551, I have updated the ssr-caching example to include logic for bypassing the cache when the server returns a 404 response.

@fabianishere
Do not cache 404 SSR responses
c5b6c49 
This change updates the _ssr-caching_ to not cache the response when a
404 status code has been returned.
@fabianishere fabianishere force-pushed the example/404-cached-route branch from 73c48b4 to c5b6c49 Compare February 19, 2020 15:04
@ijjk
Copy link
Member

ijjk commented Feb 19, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary fabianishere/next.js example/404-cached-route Change
buildDuration 9.9s 10.3s ⚠️ +455ms
nodeModulesSize 53.8 MB 53.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary fabianishere/next.js example/404-cached-route Change
main-HASH.js gzip 5.05 kB 5.05 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..abdd.js gzip 12.2 kB 12.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary fabianishere/next.js example/404-cached-route Change
main-HASH.module.js gzip 4.14 kB 4.14 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.2 kB 9.2 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary fabianishere/next.js example/404-cached-route Change
polyfills-HASH.js gzip 20.3 kB 20.3 kB ✓
Overall change 20.3 kB 20.3 kB ✓
Client Pages
zeit/next.js canary fabianishere/next.js example/404-cached-route Change
_app.js gzip 1.06 kB 1.06 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary fabianishere/next.js example/404-cached-route Change
_app.module.js gzip 577 B 577 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary fabianishere/next.js example/404-cached-route Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary fabianishere/next.js example/404-cached-route Change
index.html gzip 925 B 925 B ✓
link.html gzip 933 B 933 B ✓
withRouter.html gzip 922 B 922 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary fabianishere/next.js example/404-cached-route Change
buildDuration 10.8s 10.8s ⚠️ +48ms
nodeModulesSize 53.8 MB 53.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary fabianishere/next.js example/404-cached-route Change
main-HASH.js gzip 5.05 kB 5.05 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..abdd.js gzip 12.2 kB 12.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary fabianishere/next.js example/404-cached-route Change
main-HASH.module.js gzip 4.14 kB 4.14 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.2 kB 9.2 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary fabianishere/next.js example/404-cached-route Change
polyfills-HASH.js gzip 20.3 kB 20.3 kB ✓
Overall change 20.3 kB 20.3 kB ✓
Client Pages
zeit/next.js canary fabianishere/next.js example/404-cached-route Change
_app.js gzip 1.06 kB 1.06 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary fabianishere/next.js example/404-cached-route Change
_app.module.js gzip 577 B 577 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary fabianishere/next.js example/404-cached-route Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary fabianishere/next.js example/404-cached-route Change
_error.js gzip 289 kB 289 kB -40 B
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 964 B 964 B ✓
index.js gzip 290 kB 289 kB -783 B
link.js gzip 298 kB 299 kB ⚠️ +669 B
routerDirect.js gzip 298 kB 296 kB -1.68 kB
withRouter.js gzip 296 kB 297 kB ⚠️ +300 B
Overall change 1.47 MB 1.47 MB -1.53 kB

Commit: c5b6c49

@Timer Timer added ready to land examples Issue was opened via the examples template. labels Feb 19, 2020
Timer
Timer approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Timer Timer added this to the 9.3.0 milestone Feb 19, 2020
@Timer Timer merged commit 72a461f into vercel:canary Feb 19, 2020
@snyk-bot snyk-bot mentioned this pull request Apr 9, 2020
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianishere @ijjk @Timer