Update handling for patterns in custom routes #10523

ijjk · 2020-02-13T17:48:35Z

As discussed, this updates our handling for un-named params to only allow them to be used in the source and not allowed to be used in the destination. It also updates to not validate when compiling the destination to allow named patterns to be compiled correctly and we should have already validated the route is valid before it get's to this point

Closes: #10291

ijjk · 2020-02-13T17:54:21Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
buildDuration	11.2s	11s	-251ms
nodeModulesSize	52.9 MB	52.9 MB	⚠️ +3.3 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..c95c.js gzip	13.6 kB	13.6 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
main-HASH.module.js gzip	4.13 kB	4.13 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.4 kB	12.4 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62 kB	62 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
index.html gzip	1.03 kB	1.03 kB	✓
link.html gzip	1.04 kB	1.04 kB	✓
withRouter.html gzip	1.03 kB	1.03 kB	✓
Overall change	3.11 kB	3.11 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
buildDuration	11.9s	12s	⚠️ +183ms
nodeModulesSize	52.9 MB	52.9 MB	⚠️ +3.3 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..c95c.js gzip	13.6 kB	13.6 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
main-HASH.module.js gzip	4.13 kB	4.13 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.4 kB	12.4 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62 kB	62 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
_error.js gzip	289 kB	289 kB	-18 B
404.html gzip	1.44 kB	1.44 kB	✓
hooks.html gzip	1.08 kB	1.08 kB	✓
index.js gzip	290 kB	290 kB	⚠️ +159 B
link.js gzip	319 kB	319 kB	⚠️ +269 B
routerDirect.js gzip	317 kB	316 kB	-377 B
withRouter.js gzip	315 kB	316 kB	⚠️ +787 B
Overall change	1.53 MB	1.53 MB	⚠️ +820 B

Commit: 370dfce

…tches-handling

ijjk · 2020-03-10T19:53:14Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
buildDuration	8.8s	8.8s	⚠️ +80ms
nodeModulesSize	56.5 MB	56.5 MB	⚠️ +4.26 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
main-HASH.js gzip	5.77 kB	5.77 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..cfaa.js gzip	9.77 kB	9.77 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.4 kB	55.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
_app.js gzip	1.09 kB	1.09 kB	✓
_error.js gzip	2.96 kB	2.96 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.06 kB	2.06 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
index.html gzip	916 B	916 B	✓
link.html gzip	925 B	925 B	✓
withRouter.html gzip	914 B	914 B	✓
Overall change	2.75 kB	2.75 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
buildDuration	9.7s	9.6s	-136ms
nodeModulesSize	56.5 MB	56.5 MB	⚠️ +4.26 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
main-HASH.js gzip	5.77 kB	5.77 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..cfaa.js gzip	9.77 kB	9.77 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.4 kB	55.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
_app.js gzip	1.09 kB	1.09 kB	✓
_error.js gzip	2.96 kB	2.96 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.06 kB	2.06 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js update/unnamed-matches-handling	Change
_error.js gzip	294 kB	293 kB	-420 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	956 B	956 B	✓
index.js gzip	293 kB	294 kB	⚠️ +789 B
link.js gzip	301 kB	300 kB	-43 B
routerDirect.js gzip	300 kB	300 kB	⚠️ +235 B
withRouter.js gzip	300 kB	300 kB	⚠️ +134 B
Overall change	1.49 MB	1.49 MB	⚠️ +695 B

* Update handling for unnamed params and named patterns in custom-routes * Update query handling to match Now

Update handling for unnamed params and named patterns in custom-routes

370dfce

ijjk added the Type: Bug label Feb 13, 2020

ijjk added this to the 9.2.x milestone Feb 13, 2020

ijjk requested review from lfades, Timer and timneutkens as code owners February 13, 2020 17:48

ijjk added 3 commits March 10, 2020 11:27

Merge remote-tracking branch 'upstream/canary' into update/unnamed-ma…

4e9731f

…tches-handling

Merge remote-tracking branch 'upstream/canary' into update/unnamed-ma…

31aff85

…tches-handling

Update query handling to match Now

50337d5

Timer approved these changes Mar 10, 2020

View reviewed changes

Timer changed the title ~~Update handling for un-named params and named patterns in custom-routes~~ Update handling for patterns in custom routes Mar 10, 2020

Timer merged commit 6616a37 into vercel:canary Mar 10, 2020

Timer deleted the update/unnamed-matches-handling branch March 10, 2020 20:09

ScriptedAlchemy pushed a commit to module-federation/next.js that referenced this pull request Mar 17, 2020

Update handling for patterns in custom routes (vercel#10523)

14409b7

* Update handling for unnamed params and named patterns in custom-routes * Update query handling to match Now

snyk-bot mentioned this pull request Apr 9, 2020

[Snyk] Upgrade next from 9.1.1 to 9.3.1 cds-snc/a11y-reporting#6

Open

Timer removed this from the 10.x.x milestone Nov 16, 2020

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update handling for patterns in custom routes #10523

Update handling for patterns in custom routes #10523

ijjk commented Feb 13, 2020

ijjk commented Feb 13, 2020

ijjk commented Mar 10, 2020

Update handling for patterns in custom routes #10523

Update handling for patterns in custom routes #10523

Conversation

ijjk commented Feb 13, 2020

ijjk commented Feb 13, 2020

Stats from current PR

ijjk commented Mar 10, 2020

Stats from current PR