Disable v8cache on Windows only #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
==========================================
+ Coverage 73.29% 73.48% +0.18%
==========================================
Files 14 13 -1
Lines 397 396 -1
==========================================
Hits 291 291
+ Misses 106 105 -1
Continue to review full report at Codecov.
|
styfle
reviewed
May 22, 2019
styfle
approved these changes
May 23, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative workaround for #395 given that disabling the v8 cache in #403 turned out to be such a large performance regression.
Since the bug report came from Azure on Node.js 10, this just disables using the v8cache in Windows only as part of the cache runtime itself.