New analysis updates

[guybedford]

This updates to [email protected], which includes resolutions for the following ncc bugs:

• Running a file that requires lighthouse breaks #290 (integration test included)
• Fails at runtime with @ffmpeg-installer/ffmpeg package #376 (integration test included)
• Avoid the use of __dirname when importing files dynamically #216
• Failed to run pdf2json: ENOENT no such file or directory #349 (integration test included)
• Supporting require.resolve dynamic passing #41
• Avoid the use of __dirname when importing files dynamically #216
• Supporting __dirname wildcards #297
• Cannot find module 'socket.io-client/dist/socket.io.js' #148
• .ts files being added to the end build #156
• Feature Request: do not transform build-in require function #248
• "Dynamic requires" not at all working. #383

The full description of the analysis changes is in vercel/webpack-asset-relocator-loader#30.

In ncc itself we also change not found errors into runtime errors and remove the external warnings for not-found requires.

[guybedford]

In addition - package resolutions are attempted for resolution at runtime before throwing a not found error.

[codecov-io]

Codecov Report

Merging #378 into master will decrease coverage by 1.11%.
The diff coverage is 73.07%.

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   74.41%   73.29%   -1.12%     
==========================================
  Files          12       14       +2     
  Lines         387      397      +10     
==========================================
+ Hits          288      291       +3     
- Misses         99      106       +7

Impacted Files	Coverage Δ
src/@@notfound.js	0% <0%> (ø)
src/loaders/notfound-loader.js	100% <100%> (ø)
src/index.js	83.12% <92.85%> (-0.83%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5033ed...698583c. Read the comment docs.

[styfle]

This change also allows us to remove the entire code path around the custom externals function we have, which is currently double-resolving all package resolutions (and incurring the statting and performance costs of that). I haven't removed it here because the externals warning is a feature we need to consider if we want to remove, but I would personally be quite happy removing those logs too.

If these warnings are decreasing performance, we should remove them.

Like you mentioned before: if the module require is tried at runtime and not found, then there will be an error instead. I think this error is pretty self-explanatory.

Error: Cannot find module 'unknown'

[styfle]

Can all those issues be closed now?

[guybedford]

Yes, all those issues can be closed!