From 8d9da0a3eccd345e2a64e31d5997c2fe2734ea5b Mon Sep 17 00:00:00 2001 From: Andrea Panattoni Date: Fri, 24 Nov 2023 11:08:52 +0100 Subject: [PATCH] envtest: Stick to a specific setup-envtest version Using `@latest` for tools dependecies produces unrepeatable builds which might break at any point in time. This is particularly important when maintaining released versions which need a backport fix. Note: At the moment is not possible to reference the package `sigs.k8s.io/controller-runtime/tools/setup-envtest` with a specific version: ``` go: sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.16.3: module sigs.k8s.io/controller-runtime@v0.16.3 found, but does not contain package sigs.k8s.io/controller-runtime/tools/setup-envtest ``` See https://github.com/kubernetes-sigs/kubebuilder/issues/2480 Ref: https://github.com/openshift/sriov-network-operator/pull/849 Signed-off-by: Andrea Panattoni --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index eeade0110..64a89d2f1 100644 --- a/Makefile +++ b/Makefile @@ -155,7 +155,7 @@ kustomize: ## Download kustomize locally if necessary. ENVTEST = $(BIN_DIR)/setup-envtest envtest: ## Download envtest-setup locally if necessary. - $(call go-install-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest@latest) + $(call go-install-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest@release-0.16) GOMOCK = $(shell pwd)/bin/mockgen gomock: